Merge pull request #4832 from NativeScript/fatme/fix-less-warning

Fatme · web-flow · commit c978bcf5eba2 · 2019-07-10T18:00:21.000+03:00
fix: show warning for less only when the project has nativescript-dev-less plugin as dependency
diff --git a/lib/controllers/migrate-controller.ts b/lib/controllers/migrate-controller.ts
@@ -311,7 +311,7 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
 
 	private async migrateDependency(dependency: IMigrationDependency, projectData: IProjectData): Promise<void> {
 		const hasDependency = this.hasDependency(dependency, projectData);
-		if (dependency.warning) {
+		if (hasDependency && dependency.warning) {
 			this.$logger.warn(dependency.warning);
 		}
 

Original file line number	Diff line number	Diff line change
@@ -311,7 +311,7 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
`311`	`311`
`312`	`312`	`private async migrateDependency(dependency: IMigrationDependency, projectData: IProjectData): Promise<void> {`
`313`	`313`	`const hasDependency = this.hasDependency(dependency, projectData);`
`314`		`- if (dependency.warning) {`
	`314`	`+ if (hasDependency && dependency.warning) {`
`315`	`315`	`this.$logger.warn(dependency.warning);`
`316`	`316`	`}`
`317`	`317`