Skip to content

Commit b700c03

Browse files
FatmeFatme
Fatme
authored and
Fatme
committed
Merge pull request #751 from NativeScript/fatme/update-default-timeout
Update the default timeout used from debug command to 90 seconds
2 parents e66b921 + 58c12db commit b700c03

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

docs/man_pages/project/testing/debug-android.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Debugs your project on a connected device, in a native emulator or in Genymotion
2323
* `--stop` - Detaches the debug tools.
2424
* `--get-port` - Retrieves the port on which you are debugging your application.
2525
* `--debug-port` - Sets a new port on which to attach the debug tools.
26-
* `--timeout` - Sets the number of seconds that NativeScript CLI will wait for the debugger to boot. If not set, the default timeout is 60 seconds.
26+
* `--timeout` - Sets the number of seconds that NativeScript CLI will wait for the debugger to boot. If not set, the default timeout is 90 seconds.
2727

2828
### Attributes
2929
* `<Device ID>` is the index or name of the target device as listed by `$ tns device`

docs/man_pages/project/testing/debug-ios.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Debugs your project on a connected device or in the iOS Simulator. <% if(isHtml)
2020
* `--start` - Attaches the debug tools to a deployed and running app and launches the developer tools of your Safari browser.
2121
* `--emulator` - Indicates that you want to debug your app in the iOS simulator.
2222
* `--no-client` - If set, the NativeScript CLI attaches the debug tools but does not launch the developer tools in Safari.
23-
* `--timeout` - Sets the number of seconds that NativeScript CLI will wait for the debugger to boot. If not set, the default timeout is 60 seconds.
23+
* `--timeout` - Sets the number of seconds that NativeScript CLI will wait for the debugger to boot. If not set, the default timeout is 90 seconds.
2424

2525
### Attributes
2626
* `<Device ID>` is the index or name of the target device as listed by `$ tns device`

lib/services/android-debug-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ class AndroidDebugService implements IDebugService {
200200
private startAndGetPort(packageName: string): IFuture<number> {
201201
return (() => {
202202
let port = -1;
203-
let timeout = this.$utils.getParsedTimeout(60);
203+
let timeout = this.$utils.getParsedTimeout(90);
204204

205205
let packageDir = util.format(AndroidDebugService.PACKAGE_EXTERNAL_DIR_TEMPLATE, packageName);
206206
let envDebugInFullpath = packageDir + AndroidDebugService.ENV_DEBUG_IN_FILENAME;

lib/services/ios-debug-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ function connectEventually(factory: () => net.Socket, handler: (socket: net.Sock
6060
}
6161

6262
class IOSDebugService implements IDebugService {
63-
private static TIMEOUT_SECONDS = 60;
63+
private static TIMEOUT_SECONDS = 90;
6464

6565
constructor(
6666
private $platformService: IPlatformService,

0 commit comments

Comments
 (0)