Merge pull request #42 from NativeScript/vladimirov/compile-sdk-28

rosen-vladimirov · web-flow · commit afefd4c91b01 · 2018-09-28T14:32:15.000+03:00
feat: allow using android-28 SDK for building apps
diff --git a/lib/android-tools-info.ts b/lib/android-tools-info.ts
@@ -9,7 +9,19 @@ import * as path from "path";
 
 export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
 	private static ANDROID_TARGET_PREFIX = "android";
-	private static SUPPORTED_TARGETS = ["android-17", "android-18", "android-19", "android-21", "android-22", "android-23", "android-24", "android-25", "android-26", "android-27"];
+	private static SUPPORTED_TARGETS = [
+		"android-17",
+		"android-18",
+		"android-19",
+		"android-21",
+		"android-22",
+		"android-23",
+		"android-24",
+		"android-25",
+		"android-26",
+		"android-27",
+		"android-28",
+	];
 	private static MIN_REQUIRED_COMPILE_TARGET = 22;
 	private static REQUIRED_BUILD_TOOLS_RANGE_PREFIX = ">=23";
 	private static VERSION_REGEX = /((\d+\.){2}\d+)/;
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nativescript-doctor",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "Library that helps identifying if the environment can be used for development of {N} apps.",
   "main": "lib/index.js",
   "types": "./typings/nativescript-doctor.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "nativescript-doctor",`
`3`		`- "version": "1.3.0",`
	`3`	`+ "version": "1.4.0",`
`4`	`4`	`"description": "Library that helps identifying if the environment can be used for development of {N} apps.",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"types": "./typings/nativescript-doctor.d.ts",`