chore: fix comments aab

Author: KristianDD

lib/helpers/android-bundle-validator-helper.ts

@@ -1,4 +1,3 @@
-import * as semver from "semver";
 import * as util from "util";
 import { AndroidBundleValidatorMessages, TNS_ANDROID_RUNTIME_NAME } from "../constants";
 import { VersionValidatorHelper } from "./version-validator-helper";
@@ -23,10 +22,11 @@ export class AndroidBundleValidatorHelper extends VersionValidatorHelper impleme
 		if (this.$options.aab) {
 			const androidRuntimeInfo = this.$projectDataService.getNSValue(projectData.projectDir, TNS_ANDROID_RUNTIME_NAME);
 			const androidRuntimeVersion = androidRuntimeInfo ? androidRuntimeInfo.version : "";
-
-			if (androidRuntimeVersion &&
+			const shouldThrowError = androidRuntimeVersion &&
 				this.isValidVersion(androidRuntimeVersion) &&
-				!this.compareCoerceVersions(androidRuntimeVersion, AndroidBundleValidatorHelper.MIN_RUNTIME_VERSION, semver.gte)) {
+				this.isVersionLowerThan(androidRuntimeVersion, AndroidBundleValidatorHelper.MIN_RUNTIME_VERSION);
+
+			if (shouldThrowError) {
 				this.$errors.failWithoutHelp(util.format(AndroidBundleValidatorMessages.NOT_SUPPORTED_RUNTIME_VERSION, AndroidBundleValidatorHelper.MIN_RUNTIME_VERSION));
 			}
 		}

lib/helpers/bundle-validator-helper.ts

@@ -1,4 +1,3 @@
-import * as semver from "semver";
 import * as util from "util";
 import { BundleValidatorMessages } from "../constants";
 import { VersionValidatorHelper } from "./version-validator-helper";
@@ -25,7 +24,8 @@ export class BundleValidatorHelper extends VersionValidatorHelper implements IBu
 			}
 
 			const currentVersion = bundlerVersionInDependencies || bundlerVersionInDevDependencies;
-			if (minSupportedVersion && this.isValidVersion(currentVersion) && !this.compareCoerceVersions(currentVersion, minSupportedVersion, semver.gte)) {
+			const shouldThrowError = minSupportedVersion && this.isValidVersion(currentVersion) && this.isVersionLowerThan(currentVersion, minSupportedVersion);
+			if (shouldThrowError) {
 					this.$errors.failWithoutHelp(util.format(BundleValidatorMessages.NotSupportedVersion, minSupportedVersion));
 			}
 		}

lib/helpers/version-validator-helper.ts

@@ -6,7 +6,23 @@ export class VersionValidatorHelper {
 		return semver.valid(version) || semver.validRange(version);
 	}
 
-	protected compareCoerceVersions(version: string, minVersion: string, comperator: Function): boolean {
-		return comperator(semver.coerce(version), semver.coerce(minVersion));
+	protected isVersionGreaterThan(v1: string, v2: string): boolean {
+		return this.compareCoerceVersions(v1, v2, semver.gt);
+	}
+
+	protected isVersionGreaterOrEqualThan(v1: string, v2: string): boolean {
+		return this.compareCoerceVersions(v1, v2, semver.gte);
+	}
+
+	protected isVersionLowerThan(v1: string, v2: string): boolean {
+		return this.compareCoerceVersions(v1, v2, semver.lt);
+	}
+
+	protected isVersionLowerOrEqualThan(v1: string, v2: string): boolean {
+		return this.compareCoerceVersions(v1, v2, semver.lte);
+	}
+
+	private compareCoerceVersions(version: string, minVersion: string, condition: Function): boolean {
+		return condition(semver.coerce(version), semver.coerce(minVersion));
 	}
 }