Skip to content

Commit a4c11e5

Browse files
fix: Changes in node_modules are always skipped
Currently all changes in `node_modules` are skipped as we do not check for changes in case `--syncAllFiles` is not passed. In fact the meaning of this option is for LiveSync operations and by default CLI does not watch for changes in node_modules. However, the separate commands like prepare, build, test and even the initial LiveSync must check the node_modules and prepare the correct files. In latest versions (4.2.x) we were always checking all `node_modules` even during change of a single file during LiveSync. After that we've applied a change in the current master branch to skip node_modules check in case specific option is passed to the projectChangesService. The problem with latest approach is that we've missed this option is always passed based on syncAllFiles. This led to the problem that once you have node_modules setup, CLI from master branch never checks for changes in these files and does not move them to platforms dir. With the current changes, node_modules will be checked on all commands. Once LiveSync starts, all consecutive changes in project files will not check node_modules unless `syncAllFiles` option is passed to CLI.
1 parent 0f403d2 commit a4c11e5

File tree

5 files changed

+0
-6
lines changed

5 files changed

+0
-6
lines changed

lib/commands/appstore-upload.ts

-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export class PublishIOS implements ICommand {
6060
const platformInfo: IPreparePlatformInfo = {
6161
platform,
6262
appFilesUpdaterOptions,
63-
skipModulesNativeCheck: !this.$options.syncAllFiles,
6463
platformTemplate: this.$options.platformTemplate,
6564
projectData: this.$projectData,
6665
config: this.$options,

lib/commands/build.ts

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export class BuildCommandBase {
1717
const platformInfo: IPreparePlatformInfo = {
1818
platform,
1919
appFilesUpdaterOptions,
20-
skipModulesNativeCheck: !this.$options.syncAllFiles,
2120
platformTemplate: this.$options.platformTemplate,
2221
projectData: this.$projectData,
2322
config: this.$options,

lib/commands/prepare.ts

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export class PrepareCommand implements ICommand {
1414
const platformInfo: IPreparePlatformInfo = {
1515
platform: args[0],
1616
appFilesUpdaterOptions,
17-
skipModulesNativeCheck: !this.$options.syncAllFiles,
1817
platformTemplate: this.$options.platformTemplate,
1918
projectData: this.$projectData,
2019
config: this.$options,

lib/services/livesync/livesync-service.ts

-1
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,6 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
469469
deviceBuildInfoDescriptor,
470470
liveSyncData,
471471
settings,
472-
skipModulesNativeCheck: !liveSyncData.watchAllFiles,
473472
bundle: liveSyncData.bundle,
474473
release: liveSyncData.release,
475474
env: liveSyncData.env

lib/services/test-execution-service.ts

-2
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ class TestExecutionService implements ITestExecutionService {
5959
const preparePlatformInfo: IPreparePlatformInfo = {
6060
platform,
6161
appFilesUpdaterOptions,
62-
skipModulesNativeCheck: !this.$options.syncAllFiles,
6362
platformTemplate: this.$options.platformTemplate,
6463
projectData,
6564
config: this.$options,
@@ -187,7 +186,6 @@ class TestExecutionService implements ITestExecutionService {
187186
const preparePlatformInfo: IPreparePlatformInfo = {
188187
platform,
189188
appFilesUpdaterOptions,
190-
skipModulesNativeCheck: !this.$options.syncAllFiles,
191189
platformTemplate: this.$options.platformTemplate,
192190
projectData,
193191
config: this.$options,

0 commit comments

Comments
 (0)