Skip to content

Commit a2c64f9

Browse files
Merge pull request #4457 from NativeScript/tachev/hmr-out-of-beta
fix: remove the HMR Beta warnings as all critical issue are fixed
2 parents ccfe399 + 5d955df commit a2c64f9

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

lib/services/livesync/livesync-service.ts

-7
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
5050

5151
public async liveSync(deviceDescriptors: ILiveSyncDeviceInfo[], liveSyncData: ILiveSyncInfo): Promise<void> {
5252
const projectData = this.$projectDataService.getProjectData(liveSyncData.projectDir);
53-
this.handleWarnings(liveSyncData, projectData);
5453
await this.$pluginsService.ensureAllDependenciesAreInstalled(projectData);
5554
await this.liveSyncOperation(deviceDescriptors, liveSyncData, projectData);
5655
}
@@ -145,12 +144,6 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
145144
}
146145
}
147146

148-
private handleWarnings(liveSyncData: ILiveSyncInfo, projectData: IProjectData) {
149-
if (liveSyncData.useHotModuleReload) {
150-
this.$logger.warn("Hot Module Replacement (HMR) is currently in Beta. For more information about the current development state and any known issues, please check the relevant GitHub issue: https://github.com/NativeScript/NativeScript/issues/6398");
151-
}
152-
}
153-
154147
@performanceLog()
155148
private async refreshApplication(projectData: IProjectData, liveSyncResultInfo: ILiveSyncResultInfo, debugOpts?: IDebugOptions, outputPath?: string): Promise<IRefreshApplicationInfo | IDebugInformation> {
156149
const deviceDescriptor = this.getDeviceDescriptor(liveSyncResultInfo.deviceAppData.device.deviceInfo.identifier, projectData.projectDir);

0 commit comments

Comments
 (0)