Skip to content

Commit a1ed578

Browse files
PeterStaevrosen-vladimirov
authored andcommitted
changes requested from review
1 parent ac301ba commit a1ed578

File tree

1 file changed

+11
-23
lines changed

1 file changed

+11
-23
lines changed

lib/services/ios-project-service.ts

+11-23
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
258258
<dict>
259259
<key>method</key>
260260
<string>${exportOptionsMethod}</string>
261+
<key>uploadBitcode</key>
262+
<false/>
261263
</dict>
262264
</plist>`;
263265

@@ -1346,30 +1348,16 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
13461348
}
13471349
}
13481350

1349-
private async getEmbeddedPlistData(projectData: IProjectData): Promise<IDictionary<any>> {
1350-
let embeddedPlistContents = "";
1351+
private getExportOptionsMethod(projectData: IProjectData): string {
13511352
const embeddedMobileProvisionPath = path.join(this.getPlatformData(projectData).deviceBuildOutputPath, `${projectData.projectName}.app`, "embedded.mobileprovision");
1352-
1353-
embeddedPlistContents = await this.$childProcess.exec(`security cms -D -i ${embeddedMobileProvisionPath}`);
1354-
1355-
return plist.parse(embeddedPlistContents);
1356-
}
1357-
1358-
private async getExportOptionsMethod(projectData: IProjectData): Promise<"app-store" | "ad-hoc" | "enterprise" | "development"> {
1359-
const embeddedPlistData = await this.getEmbeddedPlistData(projectData);
1360-
1361-
if (embeddedPlistData.ProvisionsAllDevices) {
1362-
return "enterprise";
1363-
} else if (embeddedPlistData.ProvisionedDevices && embeddedPlistData.ProvisionedDevices.length) {
1364-
const entitlements = embeddedPlistData.Entitlements;
1365-
if (entitlements["get-task-allow"]) {
1366-
return "development";
1367-
} else {
1368-
return "ad-hoc";
1369-
}
1370-
} else {
1371-
return "app-store";
1372-
}
1353+
const provision = mobileprovision.provision.readFromFile(embeddedMobileProvisionPath);
1354+
1355+
return {
1356+
"Development": "development",
1357+
"AdHoc": "ad-hoc",
1358+
"Distribution": "app-store",
1359+
"Enterprise": "enterprise"
1360+
}[provision.Type];
13731361
}
13741362
}
13751363

0 commit comments

Comments
 (0)