Fix ENOENT error when add ios platform

Author: Fatme

lib/common

@@ -15,6 +15,7 @@ interface INpmInstallationManager {
 	cacheUnpack(packageName: string, version: string, unpackTarget?: string): IFuture<void>;
 	install(packageName: string, options?: INpmInstallOptions): IFuture<string>;
 	getLatestVersion(packageName: string): IFuture<string>;
+	getLatestCompatibleVersion(packageName: string): IFuture<string>;
 	getCachedPackagePath(packageName: string, version: string): string;
 	addCleanCopyToCache(packageName: string, version: string): IFuture<void>;
 }

lib/declarations.ts

@@ -6,6 +6,12 @@ import semver = require("semver");
 import * as npm from "npm";
 import * as constants from "./constants";
 
+interface IVersionData {
+	major: string;
+	minor: string;
+	patch: string;
+}
+
 export class NpmInstallationManager implements INpmInstallationManager {
 	private static NPM_LOAD_FAILED = "Failed to retrieve data from npm. Please try again a little bit later.";
 	private versionsCache: IDictionary<string[]>;
@@ -20,7 +26,8 @@ export class NpmInstallationManager implements INpmInstallationManager {
 		private $lockfile: ILockFile,
 		private $errors: IErrors,
 		private $options: IOptions,
-		private $fs: IFileSystem) {
+		private $fs: IFileSystem,
+		private $staticConfig: IStaticConfig) {
 		this.versionsCache = {};
 		this.$npm.load().wait();
 	}
@@ -63,6 +70,27 @@ export class NpmInstallationManager implements INpmInstallationManager {
 		}).future<string>()();
 	}
 
+	public getLatestCompatibleVersion(packageName: string): IFuture<string> {
+		return (() => {
+			let latestVersion = this.getLatestVersion(packageName).wait();
+			let data = this.$npm.view(packageName, "versions").wait();
+			let versions: string[] = data[latestVersion].versions;
+
+			let versionData = this.getVersionData(this.$staticConfig.version);
+
+ 			let compatibleVersions = _(versions)
+				.map(ver => this.getVersionData(ver))
+				.filter(verData => versionData.major === verData.major && versionData.minor === verData.minor)
+				.sortBy(verData => verData.patch)
+				.value();
+
+			let result = _.last(compatibleVersions);
+
+			let latestCompatibleVersion = `${result.major}.${result.minor}.${result.patch}`;
+			return latestCompatibleVersion;
+		}).future<string>()();
+	}
+
 	public install(packageName: string, opts?: INpmInstallOptions): IFuture<string> {
 		return (() => {
 			this.$lockfile.lock().wait();
@@ -131,7 +159,7 @@ export class NpmInstallationManager implements INpmInstallationManager {
 				}
 				return this.$options.frameworkPath;
 			} else {
-				version = version || this.getLatestVersion(packageName).wait();
+				version = version || this.getLatestCompatibleVersion(packageName).wait();
 				let packagePath = this.getCachedPackagePath(packageName, version);
 				this.addToCache(packageName, version).wait();
 				return packagePath;
@@ -163,5 +191,10 @@ export class NpmInstallationManager implements INpmInstallationManager {
 			return this.$fs.exists(directory).wait() &&	this.$fs.enumerateFilesInDirectorySync(directory).length > 0;
 		}).future<boolean>()();
 	}
+
+	private getVersionData(version: string): IVersionData {
+		let [ major, minor, patch ] = version.split(".");
+		return { major, minor, patch };
+	}
 }
 $injector.register("npmInstallationManager", NpmInstallationManager);

lib/npm-installation-manager.ts

@@ -99,7 +99,7 @@ export class InitService implements IInitService {
 
 	private getVersionData(packageName: string): IFuture<IStringDictionary> {
 		return (() => {
-			let latestVersion = this.$npmInstallationManager.getLatestVersion(packageName).wait();
+			let latestVersion = this.$npmInstallationManager.getLatestCompatibleVersion(packageName).wait();
 			if(this.useDefaultValue) {
 				return this.buildVersionData(latestVersion);
 			}

lib/services/init-service.ts

@@ -0,0 +1,95 @@
+/// <reference path=".d.ts" />
+"use strict";
+
+import {assert} from "chai";
+import * as ConfigLib from "../lib/config";
+import * as ErrorsLib from "../lib/common/errors";
+import * as FsLib from "../lib/common/file-system";
+import * as HostInfoLib from "../lib/common/host-info";
+import * as LoggerLib from "../lib/common/logger";
+import * as NpmInstallationManagerLib from "../lib/npm-installation-manager";
+import * as OptionsLib from "../lib/options";
+import * as StaticConfigLib from "../lib/config";
+
+import Future = require("fibers/future");
+import yok = require("../lib/common/yok");
+
+function createTestInjector(): IInjector {
+	let testInjector = new yok.Yok();
+
+	testInjector.register("config", ConfigLib.Configuration);
+	testInjector.register("logger", LoggerLib.Logger);
+	testInjector.register("lockfile", { });
+	testInjector.register("errors", ErrorsLib.Errors);
+	testInjector.register("options", OptionsLib.Options);
+	testInjector.register("fs", FsLib.FileSystem);
+	testInjector.register("hostInfo", HostInfoLib.HostInfo);
+	testInjector.register("staticConfig", StaticConfigLib.StaticConfig);
+
+	testInjector.register("npmInstallationManager", NpmInstallationManagerLib.NpmInstallationManager);
+
+	return testInjector;
+}
+
+function mockNpm(testInjector: IInjector, versions: string[], latestVersion: string) {
+	testInjector.register("npm", {
+		view: (packageName: string, propertyName: string) => {
+			return (() => {
+				if(propertyName === "versions") {
+					let result = Object.create(null);
+					result[latestVersion] = {
+						"versions": versions
+					};
+
+					return result;
+				}
+
+				throw new Error(`Unable to find propertyName ${propertyName}.`);
+			}).future<any>()();
+		},
+		load: () => Future.fromResult()
+	});
+}
+
+describe("Npm installation manager tests", () => {
+	it("returns correct latest compatible version when only one exists", () => {
+		let testInjector = createTestInjector();
+
+		let versions = ["1.4.0"];
+		let latestVersion = "1.4.0";
+
+		mockNpm(testInjector, versions, latestVersion);
+
+		// Mock staticConfig.version
+		let staticConfig = testInjector.resolve("staticConfig");
+		staticConfig.version = "1.4.0";
+
+		// Mock npmInstallationManager.getLatestVersion
+		let npmInstallationManager = testInjector.resolve("npmInstallationManager");
+		npmInstallationManager.getLatestVersion = (packageName: string) => Future.fromResult(latestVersion);
+
+		let actualLatestCompatibleVersion = npmInstallationManager.getLatestCompatibleVersion("").wait();
+		let expectedLatestCompatibleVersion = "1.4.0";
+		assert.equal(actualLatestCompatibleVersion, expectedLatestCompatibleVersion);
+	});
+	it("returns correct latest compatible version", () => {
+		let testInjector = createTestInjector();
+
+		let versions = ["1.2.0", "1.3.0", "1.3.1", "1.3.2", "1.3.3", "1.4.0"];
+		let latestVersion = "1.3.3";
+
+		mockNpm(testInjector, versions, latestVersion);
+
+		// Mock staticConfig.version
+		let staticConfig = testInjector.resolve("staticConfig");
+		staticConfig.version = "1.3.0";
+
+		// Mock npmInstallationManager.getLatestVersion
+		let npmInstallationManager = testInjector.resolve("npmInstallationManager");
+		npmInstallationManager.getLatestVersion = (packageName: string) => Future.fromResult(latestVersion);
+
+		let actualLatestCompatibleVersion = npmInstallationManager.getLatestCompatibleVersion("").wait();
+		let expectedLatestCompatibleVersion = "1.3.3";
+		assert.equal(actualLatestCompatibleVersion, expectedLatestCompatibleVersion);
+	});
+});

test/npm-installation-manager.ts

@@ -223,6 +223,10 @@ export class NpmInstallationManagerStub implements INpmInstallationManager {
 		return Future.fromResult("");
 	}
 
+	getLatestCompatibleVersion(packageName: string): IFuture<string> {
+		return Future.fromResult("");
+	}
+
 	getCachedPackagePath(packageName: string, version: string): string {
 		return "";
 	}