Skip to content

Commit 9d200c3

Browse files
author
Dimitar Kerezov
committed
Fix PR comments vol 1
1 parent c791c1b commit 9d200c3

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

lib/bootstrap.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ $injector.require("projectNameService", "./services/project-name-service");
1919
$injector.require("tnsModulesService", "./services/tns-modules-service");
2020

2121
$injector.require("platformsData", "./platforms-data");
22-
$injector.requirePublic("platformService", "./services/platform-service");
22+
$injector.require("platformService", "./services/platform-service");
23+
$injector.requirePublic("localBuildService", "./services/local-build-service");
2324

2425
$injector.require("iOSDebugService", "./services/ios-debug-service");
2526
$injector.require("androidDebugService", "./services/android-debug-service");

lib/services/local-build-service.ts

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { exportedPromise } from "../common/decorators";
2+
3+
export class LocalBuildService {
4+
constructor(private $projectData: IProjectData,
5+
private $platformService: IPlatformService) { }
6+
7+
@exportedPromise("localBuildService")
8+
public async build(platform: string, platformBuildOptions: IPlatformBuildData, platformTemplate?: string): Promise<string> {
9+
this.$projectData.initializeProjectData(platformBuildOptions.projectDir);
10+
await this.$platformService.preparePlatform(platform, platformBuildOptions, platformTemplate, this.$projectData, undefined);
11+
await this.$platformService.buildPlatform(platform, platformBuildOptions, this.$projectData);
12+
return this.$platformService.lastOutputPath(platform, { isForDevice: platformBuildOptions.buildForDevice }, this.$projectData);
13+
}
14+
}
15+
16+
$injector.register("localBuildService", LocalBuildService);

lib/services/platform-service.ts

-10
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as path from "path";
22
import * as shell from "shelljs";
33
import * as constants from "../constants";
44
import * as helpers from "../common/helpers";
5-
import { exportedPromise } from "../common/decorators";
65
import * as semver from "semver";
76
import { AppFilesUpdater } from "./app-files-updater";
87
import * as temp from "temp";
@@ -23,7 +22,6 @@ export class PlatformService implements IPlatformService {
2322
constructor(private $devicesService: Mobile.IDevicesService,
2423
private $errors: IErrors,
2524
private $fs: IFileSystem,
26-
private $projectData: IProjectData,
2725
private $logger: ILogger,
2826
private $npmInstallationManager: INpmInstallationManager,
2927
private $platformsData: IPlatformsData,
@@ -358,14 +356,6 @@ export class PlatformService implements IPlatformService {
358356
}
359357
}
360358

361-
@exportedPromise("platformService")
362-
public async build(platform: string, platformBuildOptions: IPlatformBuildData, platformTemplate?: string): Promise<string> {
363-
this.$projectData.initializeProjectData(platformBuildOptions.projectDir);
364-
await this.preparePlatform(platform, platformBuildOptions, platformTemplate, this.$projectData, undefined);
365-
await this.buildPlatform(platform, platformBuildOptions, this.$projectData);
366-
return this.lastOutputPath(platform, { isForDevice: platformBuildOptions.buildForDevice }, this.$projectData);
367-
}
368-
369359
public async buildPlatform(platform: string, buildConfig: IBuildConfig, projectData: IProjectData): Promise<void> {
370360
this.$logger.out("Building project...");
371361

0 commit comments

Comments
 (0)