feat(preview-api): expose public api for getting device's warnings

Author: Fatme

lib/definitions/preview-app-livesync.d.ts

@@ -18,6 +18,7 @@ declare global {
 	}
 
 	interface IPreviewAppPluginsService {
+		getDeviceWarnings(device: Device): string[];
 		comparePluginsOnDevice(data: IPreviewAppLiveSyncData, device: Device): Promise<void>;
 		getExternalPlugins(device: Device): string[];
 	}

lib/services/livesync/playground/devices/preview-devices-service.ts

@@ -5,6 +5,10 @@ import { DeviceDiscoveryEventNames } from "../../../../common/constants";
 export class PreviewDevicesService extends EventEmitter implements IPreviewDevicesService {
 	private connectedDevices: Device[] = [];
 
+	constructor(private $previewAppPluginsService: IPreviewAppPluginsService) {
+		super();
+	}
+
 	public getConnectedDevices(): Device[] {
 		return this.connectedDevices;
 	}
@@ -27,6 +31,10 @@ export class PreviewDevicesService extends EventEmitter implements IPreviewDevic
 		return _.filter(this.connectedDevices, { platform: platform.toLowerCase() });
 	}
 
+	public getDeviceWarnings(device: Device): string[] {
+		return this.$previewAppPluginsService.getDeviceWarnings(device);
+	}
+
 	private raiseDeviceFound(device: Device) {
 		this.emit(DeviceDiscoveryEventNames.DEVICE_FOUND, device);
 		this.connectedDevices.push(device);

lib/services/livesync/playground/preview-app-plugins-service.ts

@@ -9,10 +9,23 @@ import { PLATFORMS_DIR_NAME, PACKAGE_JSON_FILE_NAME } from "../../../constants";
 export class PreviewAppPluginsService implements IPreviewAppPluginsService {
 	private previewAppVersionWarnings: IDictionary<string[]> = {};
 
-	constructor(private $fs: IFileSystem,
+	constructor(private $errors: IErrors,
+		private $fs: IFileSystem,
 		private $logger: ILogger,
 		private $pluginsService: IPluginsService) { }
 
+	public getDeviceWarnings(device: Device): string[] {
+		if (!device) {
+			this.$errors.failWithoutHelp("No device provided.");
+		}
+
+		if (!device.previewAppVersion) {
+			this.$errors.failWithoutHelp("No version of preview app provided.");
+		}
+
+		return this.previewAppVersionWarnings[device.previewAppVersion];
+	}
+
 	public async comparePluginsOnDevice(data: IPreviewAppLiveSyncData, device: Device): Promise<void> {
 		if (!this.previewAppVersionWarnings[device.previewAppVersion]) {
 			const devicePlugins = this.getDevicePlugins(device);