Skip to content

Commit 9b9aa46

Browse files
committed
Merge pull request #1287 from NativeScript/totev/improve-xml-verify-ouput-release
Improve XML parser validation output
2 parents d68ad6a + 741ef89 commit 9b9aa46

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

lib/services/platform-service.ts

+8-2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import * as helpers from "../common/helpers";
88
import * as semver from "semver";
99
import * as minimatch from "minimatch";
1010
import Future = require("fibers/future");
11+
import {EOL} from "os";
1112

1213
export class PlatformService implements IPlatformService {
1314
private static TNS_MODULES_FOLDER_NAME = "tns_modules";
@@ -179,15 +180,20 @@ export class PlatformService implements IPlatformService {
179180
.forEach(file => {
180181
let fileContents = this.$fs.readText(file).wait();
181182
let hasErrors = false;
182-
let domErrorHandler = (level:any, msg:string) => hasErrors = true;
183+
let errorOutput = "";
184+
let domErrorHandler = (level:any, msg:string) => {
185+
errorOutput += level + EOL + msg + EOL;
186+
hasErrors = true;
187+
};
183188
let parser = new DomParser({
184189
locator:{},
185190
errorHandler: domErrorHandler
186191
});
187192
parser.parseFromString(fileContents, "text/xml");
188193
xmlHasErrors = xmlHasErrors || hasErrors;
189194
if (xmlHasErrors) {
190-
this.$logger.out("Error: ".red.bold + file + " has syntax errors.".red.bold);
195+
this.$logger.warn(`${file} has syntax errors.`);
196+
this.$logger.out(errorOutput);
191197
}
192198
});
193199
return !xmlHasErrors;

0 commit comments

Comments
 (0)