Merge pull request #4771 from NativeScript/fix-hooks-execution

Fatme · web-flow · commit 96cb477d627d · 2019-06-26T10:16:00.000+03:00
fix: fix the execution of hooks when there is unresolved injected dependency
diff --git a/lib/common/services/hooks-service.ts b/lib/common/services/hooks-service.ts
@@ -120,8 +120,8 @@ export class HooksService implements IHooksService {
 				const invalidArguments = this.validateHookArguments(hookEntryPoint);
 
 				if (invalidArguments.length) {
-					this.$logger.warn(`${hookName} will NOT be executed because it has invalid arguments - ${invalidArguments.join(", ").grey}.`);
-					return;
+					this.$logger.warn(`${hook.fullPath} will NOT be executed because it has invalid arguments - ${invalidArguments.join(", ").grey}.`);
+					continue;
 				}
 
 				// HACK for backwards compatibility:

Original file line number	Diff line number	Diff line change
`@@ -120,8 +120,8 @@ export class HooksService implements IHooksService {`
`120`	`120`	`const invalidArguments = this.validateHookArguments(hookEntryPoint);`
`121`	`121`
`122`	`122`	`if (invalidArguments.length) {`
`123`		- this.$logger.warn(`${hookName} will NOT be executed because it has invalid arguments - ${invalidArguments.join(", ").grey}.`);
`124`		`- return;`
	`123`	+ this.$logger.warn(`${hook.fullPath} will NOT be executed because it has invalid arguments - ${invalidArguments.join(", ").grey}.`);
	`124`	`+ continue;`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`// HACK for backwards compatibility:`