Merge 'origin/release' into master

Author: rosen-vladimirov

CHANGELOG.md

@@ -1,5 +1,26 @@
 NativeScript CLI Changelog
 ================
+5.0.3 (2018, December 4)
+==
+### Fixed
+* [Fixed #4186](https://github.com/NativeScript/nativescript-cli/issues/4186): Fix stuck http requests/responses
+* [Fixed #4189](https://github.com/NativeScript/nativescript-cli/pull/4189): API: Fix "Cannot read property 'removeListener' of undefined" error on second stop of livesync to preview app
+
+
+5.0.2 (2018, November 29)
+==
+### Implemented
+* [Implemented #4167](https://github.com/NativeScript/nativescript-cli/pull/4167): API: Expose previewAppLiveSyncError event when some error is thrown while livesyncing to preview app
+
+### Fixed
+* [Fixed #3962](https://github.com/NativeScript/nativescript-cli/issues/3962): If command 'tns plugin create .. ' failed , directory with plugin repository name must be deleted
+* [Fixed #4053](https://github.com/NativeScript/nativescript-cli/issues/4053): Update Nativescript cli setup scripts to use android sdk 28
+* [Fixed #4077](https://github.com/NativeScript/nativescript-cli/issues/4077): Platform add with framework path and custom version breaks run with "--bundle"
+* [Fixed #4129](https://github.com/NativeScript/nativescript-cli/issues/4129): tns preview doesn't sync changes when download 2 Playground projects
+* [Fixed #4135](https://github.com/NativeScript/nativescript-cli/issues/4135): Too many TypeScript "Watching for file changes" messages in console during build
+* [Fixed #4158](https://github.com/NativeScript/nativescript-cli/pull/4158): API: reset devices list when stopLiveSync method is called
+* [Fixed #4161](https://github.com/NativeScript/nativescript-cli/pull/4161): API: raise deviceLost event after timeout of 5 seconds
+
 
 5.0.1 (2018, November 14)
 ==

PublicAPI.md

@@ -37,6 +37,7 @@ const tns = require("nativescript");
 	* [debug](#debug)
 * [liveSyncService](#livesyncservice)
 	* [liveSync](#livesync)
+	* [liveSyncToPreviewApp](#livesynctopreviewapp)
 	* [stopLiveSync](#stopLiveSync)
 	* [enableDebugging](#enableDebugging)
 	* [attachDebugger](#attachDebugger)
@@ -59,6 +60,12 @@ const tns = require("nativescript");
 	* [startEmulator](#startemulator)
 * [deviceEmitter](#deviceemitter)
 	* [events](#deviceemitterevents)
+* [previewDevicesService](#previewdevicesservice)
+	* [deviceFound](#devicefound)
+	* [deviceLost](#devicelost)
+	* [deviceLog](#devicelog)
+* [previewQrCodeService](#previewqrcodeservice)
+	* [getPlaygroundAppQrCode](#getplaygroundappqrcode)
 
 ## Module projectService
 
@@ -779,6 +786,33 @@ tns.liveSyncService.liveSync([ androidDeviceDescriptor, iOSDeviceDescriptor ], l
 	});
 ```
 
+### liveSyncToPreviewApp
+Starts a LiveSync operation to the Preview app. After scanning the QR code with the scanner provided in the NativeScript Playground app, the app will be launched on a device through the Preview app. Additionally, any changes made to the project will be automatically synchronized with the deployed app.
+
+* Definition
+```TypeScript
+/**
+ * Starts LiveSync operation by producting a QR code and starting watcher.
+ * @param {IPreviewAppLiveSyncData} liveSyncData Describes the LiveSync operation - for which project directory is the operation and other settings.
+ * @returns {Promise<IQrCodeImageData>}
+ */
+liveSyncToPreviewApp(liveSyncData: IPreviewAppLiveSyncData): Promise<IQrCodeImageData>;
+```
+
+* Usage:
+```JavaScript
+const liveSyncData = {
+	projectDir,
+	bundle: false,
+	useHotModuleReload: false,
+	env: { }
+};
+tns.liveSyncService.liveSyncToPreviewApp(liveSyncData)
+	.then(qrCodeImageData => {
+		console.log("The qrCodeImageData is: " + qrCodeImageData);
+	});
+```
+
 ### stopLiveSync
 Stops LiveSync operation. In case deviceIdentifires are passed, the operation will be stopped only for these devices.
 
@@ -1352,6 +1386,50 @@ tns.deviceEmitter.on("emulatorImageLost", (emulatorImageInfo) => {
 ```
 `emulatorImageInfo` is of type [Moble.IDeviceInfo](https://github.com/telerik/mobile-cli-lib/blob/61cdaaaf7533394afbbe84dd4eee355072ade2de/definitions/mobile.d.ts#L9-L86).
 
+## previewDevicesService
+The `previewDevicesService` module allows interaction with preview devices. You can get a list of the connected preview devices and logs from specified device.
+
+### previewDevicesEmitterEvents
+
+* `deviceFound` - Raised when the QR code is scanned with any device. The callback function will receive one argument - `device`.
+Sample usage:
+```JavaScript
+tns.previewDevicesService.on("deviceFound", device => {
+	console.log("Attached device with identifier: " + device.id);
+});
+```
+
+* `deviceLost` - Raised when the Preview app is stopped on a specified device. The callback function will receive one argument - `device`.
+Sample usage:
+```JavaScript
+tns.previewDevicesService.on("deviceLost", device => {
+	console.log("Detached device with identifier: " + device.id);
+});
+```
+
+* `deviceLog` - Raised when the app deployed in Preview app reports any information. The event is raised for any device that reports data. The callback function has two arguments - `device` and `message`. <br/><br/>
+Sample usage:
+```JavaScript
+tns.previewDevicesService.on("deviceLogData", (device, message) => {
+	console.log("Device " + device.id + " reports: " + message);
+});
+```
+
+## previewQrCodeService
+The `previewQrCodeService` exposes methods for getting information about the QR of the Playground app and deployed app in Preview app.
+
+### getPlaygroundAppQrCode
+Returns information used to generate the QR code of the Playground app.
+
+* Usage:
+```TypeScript
+tns.previewQrCodeService.getPlaygroundAppQrCode()
+	.then(result => {
+		console.log("QR code data for iOS platform: " + result.ios);
+		console.log("QR code data for Android platform: " + result.android);
+	});
+```
+
 ## How to add a new method to Public API
 CLI is designed as command line tool and when it is used as a library, it does not give you access to all of the methods. This is mainly implementation detail. Most of the CLI's code is created to work in command line, not as a library, so before adding method to public API, most probably it will require some modification.
 For example the `$options` injected module contains information about all `--` options passed on the terminal. When the CLI is used as a library, the options are not populated. Before adding method to public API, make sure its implementation does not rely on `$options`.

lib/commands/plugin/create-plugin.ts

@@ -5,6 +5,7 @@ export class CreatePluginCommand implements ICommand {
 	public allowedParameters: ICommandParameter[] = [];
 	public userMessage = "What is your GitHub username?\n(will be used to update the Github URLs in the plugin's package.json)";
 	public nameMessage = "What will be the name of your plugin?\n(use lowercase characters and dashes only)";
+	public pathAlreadyExistsMessageTemplate = "Path already exists and is not empty %s";
 	constructor(private $options: IOptions,
 		private $errors: IErrors,
 		private $terminalSpinnerService: ITerminalSpinnerService,
@@ -22,8 +23,17 @@ export class CreatePluginCommand implements ICommand {
 		const selectedPath = path.resolve(pathToProject || ".");
 		const projectDir = path.join(selectedPath, pluginRepoName);
 
-		await this.downloadPackage(selectedTemplate, projectDir);
-		await this.setupSeed(projectDir, pluginRepoName);
+		// Must be out of try catch block, because will throw error if folder alredy exists and we don't want to delete it.
+		this.ensurePackageDir(projectDir);
+
+		try {
+			await this.downloadPackage(selectedTemplate, projectDir);
+			await this.setupSeed(projectDir, pluginRepoName);
+		} catch (err) {
+			// The call to this.ensurePackageDir() above will throw error if folder alredy exists, so it is safe to delete here.
+			this.$fs.deleteDirectory(projectDir);
+			throw err;
+		}
 
 		this.$logger.printMarkdown("Solution for `%s` was successfully created.", pluginRepoName);
 	}
@@ -66,13 +76,15 @@ export class CreatePluginCommand implements ICommand {
 		}
 	}
 
-	private async downloadPackage(selectedTemplate: string, projectDir: string): Promise<void> {
+	private ensurePackageDir(projectDir: string): void {
 		this.$fs.createDirectory(projectDir);
 
 		if (this.$fs.exists(projectDir) && !this.$fs.isEmptyDir(projectDir)) {
-			this.$errors.fail("Path already exists and is not empty %s", projectDir);
+			this.$errors.fail(this.pathAlreadyExistsMessageTemplate, projectDir);
 		}
+	}
 
+	private async downloadPackage(selectedTemplate: string, projectDir: string): Promise<void> {
 		if (selectedTemplate) {
 			this.$logger.printMarkdown("Make sure your custom template is compatible with the Plugin Seed at https://github.com/NativeScript/nativescript-plugin-seed/");
 		} else {
@@ -84,9 +96,6 @@ export class CreatePluginCommand implements ICommand {
 		try {
 			spinner.start();
 			await this.$pacoteService.extractPackage(packageToInstall, projectDir);
-		} catch (err) {
-			this.$fs.deleteDirectory(projectDir);
-			throw err;
 		} finally {
 			spinner.stop();
 		}

lib/common/declarations.d.ts

@@ -163,8 +163,10 @@ declare module Server {
 	interface IRequestResponseData {
 		statusCode: number;
 		headers: { [index: string]: any };
+		complete: boolean;
 		pipe(destination: any, options?: { end?: boolean; }): IRequestResponseData;
 		on(event: string, listener: Function): void;
+		destroy(error?: Error): void;
 	}
 }
 
@@ -744,7 +746,7 @@ interface IAnalyticsSettingsService {
 	 * Gets information for projects that are exported from playground
 	 * @param projectDir Project directory path
 	 */
- 	getPlaygroundInfo(projectDir?: string): Promise<IPlaygroundInfo>;
+	getPlaygroundInfo(projectDir?: string): Promise<IPlaygroundInfo>;
 }
 
 /**