Skip to content

Commit 943b3bd

Browse files
committed
fix: fix call projectChangesService.checkForChanges regardless if skipNativePlatform is provided
1 parent 2160190 commit 943b3bd

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

lib/controllers/build-controller.ts

-4
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,6 @@ export class BuildController extends EventEmitter implements IBuildController {
8989
const outputPath = buildData.outputPath || platformData.getBuildOutputPath(buildData);
9090
const changesInfo = this.$projectChangesService.currentChanges || await this.$projectChangesService.checkForChanges(platformData, projectData, buildData);
9191

92-
if (buildData.release && changesInfo.hasChanges) {
93-
return true;
94-
}
95-
9692
if (changesInfo.changesRequireBuild) {
9793
return true;
9894
}

lib/services/platform/prepare-native-platform-service.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@ export class PrepareNativePlatformService implements IPrepareNativePlatformServi
1515
@hook('prepareNativeApp')
1616
public async prepareNativePlatform(platformData: IPlatformData, projectData: IProjectData, prepareData: IPrepareData): Promise<boolean> {
1717
const { nativePrepare, release } = prepareData;
18+
const changesInfo = await this.$projectChangesService.checkForChanges(platformData, projectData, prepareData);
1819
if (nativePrepare && nativePrepare.skipNativePrepare) {
19-
return false;
20+
return changesInfo.hasChanges;
2021
}
2122

22-
const changesInfo = await this.$projectChangesService.checkForChanges(platformData, projectData, prepareData);
23-
2423
const hasNativeModulesChange = !changesInfo || changesInfo.nativeChanged;
2524
const hasConfigChange = !changesInfo || changesInfo.configChanged;
2625
const hasChangesRequirePrepare = !changesInfo || changesInfo.changesRequirePrepare;

0 commit comments

Comments
 (0)