chore: fix incorrect assets definitions

Author: rosen-vladimirov

lib/constants.ts

@@ -162,4 +162,7 @@ export class AssetConstants {
 	public static assets = "assets";
 
 	public static sizeDelimiter = "x";
+
+	public static defaultScale = 1;
+	public static defaultOverlayImageScale = 0.8;
 }

lib/services/assets-generation/assets-generation-service.ts

@@ -1,7 +1,7 @@
 import * as Jimp from "jimp";
 import * as Color from "color";
 import { exported } from "../../common/decorators";
-import { AssetConstants } from "../../constants";
+import { AssetConstants } from '../../constants';
 
 export const enum Operations {
 	OverlayWith = "overlayWith",
@@ -66,15 +66,15 @@ export class AssetsGenerationService implements IAssetsGenerationService {
 				}
 			}
 
-			const scale = tempScale || 1;
+			const scale = tempScale || AssetConstants.defaultScale;
 
 			const outputPath = assetItem.path;
 			const width = assetItem.width * scale;
 			const height = assetItem.height * scale;
 
 			switch (operation) {
 				case Operations.OverlayWith:
-					const overlayImageScale = assetItem.overlayImageScale || 0.8;
+					const overlayImageScale = assetItem.overlayImageScale || AssetConstants.defaultOverlayImageScale;
 					const imageResize = Math.round(Math.min(width, height) * overlayImageScale);
 					const image = await this.resize(generationData.imagePath, imageResize, imageResize);
 					await this.generateImage(generationData.background, width, height, outputPath, image);

lib/services/project-data-service.ts

@@ -161,7 +161,7 @@ export class ProjectDataService implements IProjectDataService {
 
 					image.resizeOperation = image.resizeOperation || assetItem.resizeOperation;
 					image.overlayImageScale = image.overlayImageScale || assetItem.overlayImageScale;
-
+					image.scale = image.scale || assetItem.scale;
 					// break each
 					return false;
 				}

resources/assets/image-definitions.json

@@ -13,7 +13,7 @@
 				"height": 60,
 				"directory": "Assets.xcassets/AppIcon.appiconset",
 				"filename": "[email protected]",
-				"scale": "3x"
+				"scale": "2x"
 			},
 			{
 				"width": 40,