Skip to content

Commit 8a93668

Browse files
committed
Move "Skipping node_modules..." message from ios-livesync-service to livesync-command-helper
So the message will not be displayed from sidekick.
1 parent f73ec8e commit 8a93668

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

lib/helpers/livesync-command-helper.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {
1111
private $analyticsService: IAnalyticsService,
1212
private $bundleValidatorHelper: IBundleValidatorHelper,
1313
private $errors: IErrors,
14-
private $iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider) {
14+
private $iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider,
15+
private $logger: ILogger) {
1516
this.$analyticsService.setShouldDispose(this.$options.justlaunch || !this.$options.watch);
1617
}
1718

@@ -21,6 +22,10 @@ export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {
2122
}
2223

2324
public async executeCommandLiveSync(platform?: string, additionalOptions?: ILiveSyncCommandHelperAdditionalOptions) {
25+
if (!this.$options.syncAllFiles) {
26+
this.$logger.info("Skipping node_modules folder! Use the syncAllFiles option to sync files from this folder.");
27+
}
28+
2429
const emulator = this.$options.emulator;
2530
await this.$devicesService.initialize({
2631
deviceId: this.$options.device,

lib/services/livesync/ios-livesync-service.ts

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements I
3535
this.$fs.copyFile(path.join(path.dirname(projectFilesPath), `${APP_FOLDER_NAME}/*`), tempApp);
3636

3737
if (!syncInfo.syncAllFiles) {
38-
this.$logger.info("Skipping node_modules folder! Use the syncAllFiles option to sync files from this folder.");
3938
this.$fs.deleteDirectory(path.join(tempApp, TNS_MODULES_FOLDER_NAME));
4039
}
4140

0 commit comments

Comments
 (0)