Skip to content

Commit 882de49

Browse files
author
DimitarTachev
committed
docs: improve the platform add logging by listing the installed runtime version
1 parent 8f04fc8 commit 882de49

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

lib/services/platform-service.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ export class PlatformService extends EventEmitter implements IPlatformService {
120120

121121
const spinner = this.$terminalSpinnerService.createSpinner();
122122
const platformPath = path.join(projectData.platformsDir, platform);
123+
let installedPlatformVersion;
123124

124125
try {
125126
spinner.start();
@@ -128,7 +129,8 @@ export class PlatformService extends EventEmitter implements IPlatformService {
128129
await this.$pacoteService.extractPackage(packageToInstall, downloadedPackagePath);
129130
let frameworkDir = path.join(downloadedPackagePath, constants.PROJECT_FRAMEWORK_FOLDER_NAME);
130131
frameworkDir = path.resolve(frameworkDir);
131-
await this.addPlatformCore(platformData, frameworkDir, platformTemplate, projectData, config, nativePrepare);
132+
installedPlatformVersion =
133+
await this.addPlatformCore(platformData, frameworkDir, platformTemplate, projectData, config, nativePrepare);
132134
} catch (err) {
133135
this.$fs.deleteDirectory(platformPath);
134136
throw err;
@@ -137,7 +139,7 @@ export class PlatformService extends EventEmitter implements IPlatformService {
137139
}
138140

139141
this.$fs.ensureDirectoryExists(platformPath);
140-
this.$logger.out(`Platform ${platform} successfully added.`);
142+
this.$logger.out(`Platform ${platform} successfully added. v${installedPlatformVersion}`);
141143
}
142144

143145
private async addPlatformCore(platformData: IPlatformData, frameworkDir: string, platformTemplate: string, projectData: IProjectData, config: IPlatformOptions, nativePrepare?: INativePrepare): Promise<string> {
@@ -165,8 +167,7 @@ export class PlatformService extends EventEmitter implements IPlatformService {
165167
});
166168
}
167169

168-
const coreModuleName = coreModuleData.name;
169-
return coreModuleName;
170+
return installedVersion;
170171
}
171172

172173
public getInstalledPlatforms(projectData: IProjectData): string[] {

0 commit comments

Comments
 (0)