Skip to content

Commit 859bacc

Browse files
FatmeFatme
Fatme
authored and
Fatme
committed
Merge pull request #1055 from NativeScript/fatme/merge-release-1.4.1
Merge release 1.4.1
2 parents 8c96ad6 + f25090f commit 859bacc

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

lib/services/ios-project-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
572572
private removeCocoapods(pluginPlatformsFolderPath: string): IFuture<void> {
573573
return (() => {
574574
let pluginPodFilePath = path.join(pluginPlatformsFolderPath, "Podfile");
575-
if(this.$fs.exists(pluginPodFilePath).wait()) {
575+
if(this.$fs.exists(pluginPodFilePath).wait() && this.$fs.exists(this.projectPodFilePath).wait()) {
576576
let pluginPodFileContent = this.$fs.readText(pluginPodFilePath).wait();
577577
let projectPodFileContent = this.$fs.readText(this.projectPodFilePath).wait();
578578
let contentToRemove= this.buildPodfileContent(pluginPodFilePath, pluginPodFileContent);

lib/services/plugin-variables-service.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@ export class PluginVariablesService implements IPluginVariablesService {
2626
values[pluginVariableData.name] = pluginVariableValue;
2727
}).future<void>()()).wait();
2828

29-
this.$projectDataService.initialize(this.$projectData.projectDir);
30-
this.$projectDataService.setValue(this.getPluginVariablePropertyName(pluginData), values).wait();
29+
if(!_.isEmpty(values)) {
30+
this.$projectDataService.initialize(this.$projectData.projectDir);
31+
this.$projectDataService.setValue(this.getPluginVariablePropertyName(pluginData), values).wait();
32+
}
3133
}).future<void>()();
3234
}
3335

lib/services/plugins-service.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -385,9 +385,7 @@ export class PluginsService implements IPluginsService {
385385
if(!pluginVersion) {
386386
this.$logger.warn(`${pluginData.name} is not supported for ${platform}.`);
387387
isValid = false;
388-
}
389-
390-
if(semver.gt(pluginVersion, installedFrameworkVersion)) {
388+
} else if(semver.gt(pluginVersion, installedFrameworkVersion)) {
391389
this.$logger.warn(`${pluginData.name} ${pluginVersion} for ${platform} is not compatible with the currently installed framework version ${installedFrameworkVersion}.`);
392390
isValid = false;
393391
}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "nativescript",
33
"preferGlobal": true,
4-
"version": "1.4.0",
4+
"version": "1.4.2",
55
"author": "Telerik <[email protected]>",
66
"description": "Command-line interface for building NativeScript projects",
77
"bin": {

0 commit comments

Comments
 (0)