Fix tns_modules added to app dir (#3154)

In some cases `tns_modules` dir may appear in project's app dir. The issue is caused by sending Ctrl + C while `ios-sim-portable` is executing `xcrun simctl` command.
In this case, it returns empty string for applicationPath instead of breaking the CLI process. Add new check if the projectRoot on device is not empty string and update ios-sim-portable.

Author: rosen-vladimirov

lib/device-path-provider.ts

@@ -6,17 +6,17 @@ import * as path from "path";
 export class DevicePathProvider implements IDevicePathProvider {
 	constructor(private $mobileHelper: Mobile.IMobileHelper,
 		private $injector: IInjector,
-		private $iOSSimResolver: Mobile.IiOSSimResolver) {
+		private $iOSSimResolver: Mobile.IiOSSimResolver,
+		private $errors: IErrors) {
 	}
 
 	public async getDeviceProjectRootPath(device: Mobile.IDevice, options: IDeviceProjectRootOptions): Promise<string> {
 		let projectRoot = "";
 		if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform)) {
-			if (device.isEmulator) {
-				const applicationPath = this.$iOSSimResolver.iOSSim.getApplicationPath(device.deviceInfo.identifier, options.appIdentifier);
-				projectRoot = path.join(applicationPath);
-			} else {
-				projectRoot = LiveSyncPaths.IOS_DEVICE_PROJECT_ROOT_PATH;
+			projectRoot = device.isEmulator ? this.$iOSSimResolver.iOSSim.getApplicationPath(device.deviceInfo.identifier, options.appIdentifier) : LiveSyncPaths.IOS_DEVICE_PROJECT_ROOT_PATH;
+
+			if (!projectRoot) {
+				this.$errors.failWithoutHelp("Unable to get application path on device.");
 			}
 
 			if (!options.getDirname) {

npm-shrinkwrap.json

@@ -46,7 +46,7 @@
     "inquirer": "0.9.0",
     "ios-device-lib": "0.4.10",
     "ios-mobileprovision-finder": "1.0.10",
-    "ios-sim-portable": "3.1.2",
+    "ios-sim-portable": "3.1.3",
     "lockfile": "1.0.3",
     "lodash": "4.13.1",
     "log4js": "1.0.1",