Skip to content

Commit 81611d6

Browse files
committed
changes requested from review
1 parent 9eecaa1 commit 81611d6

File tree

1 file changed

+11
-23
lines changed

1 file changed

+11
-23
lines changed

lib/services/ios-project-service.ts

+11-23
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
258258
<dict>
259259
<key>method</key>
260260
<string>${exportOptionsMethod}</string>
261+
<key>uploadBitcode</key>
262+
<false/>
261263
</dict>
262264
</plist>`;
263265

@@ -1327,30 +1329,16 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
13271329
return teamId;
13281330
}
13291331

1330-
private async getEmbeddedPlistData(projectData: IProjectData): Promise<IDictionary<any>> {
1331-
let embeddedPlistContents = "";
1332+
private getExportOptionsMethod(projectData: IProjectData): string {
13321333
const embeddedMobileProvisionPath = path.join(this.getPlatformData(projectData).deviceBuildOutputPath, `${projectData.projectName}.app`, "embedded.mobileprovision");
1333-
1334-
embeddedPlistContents = await this.$childProcess.exec(`security cms -D -i ${embeddedMobileProvisionPath}`);
1335-
1336-
return plist.parse(embeddedPlistContents);
1337-
}
1338-
1339-
private async getExportOptionsMethod(projectData: IProjectData): Promise<"app-store" | "ad-hoc" | "enterprise" | "development"> {
1340-
const embeddedPlistData = await this.getEmbeddedPlistData(projectData);
1341-
1342-
if (embeddedPlistData.ProvisionsAllDevices) {
1343-
return "enterprise";
1344-
} else if (embeddedPlistData.ProvisionedDevices && embeddedPlistData.ProvisionedDevices.length) {
1345-
const entitlements = embeddedPlistData.Entitlements;
1346-
if (entitlements["get-task-allow"]) {
1347-
return "development";
1348-
} else {
1349-
return "ad-hoc";
1350-
}
1351-
} else {
1352-
return "app-store";
1353-
}
1334+
const provision = mobileprovision.provision.readFromFile(embeddedMobileProvisionPath);
1335+
1336+
return {
1337+
"Development": "development",
1338+
"AdHoc": "ad-hoc",
1339+
"Distribution": "app-store",
1340+
"Enterprise": "enterprise"
1341+
}[provision.Type];
13541342
}
13551343
}
13561344

0 commit comments

Comments
 (0)