Skip to content

Commit 81321b5

Browse files
Merge pull request #880 from NativeScript/vladimirov/fix-android-tools2
Fix errors when ANDROID_HOME is not set
2 parents c14ea14 + 7f331a6 commit 81321b5

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

lib/android-tools-info.ts

+13-5
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,14 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
146146

147147
private getBuildToolsVersion(): IFuture<string> {
148148
return ((): string => {
149-
let pathToBuildTools = path.join(this.androidHome, "build-tools");
150-
let buildToolsRange = this.getBuildToolsRange();
149+
let buildToolsVersion: string;
150+
if(this.androidHome) {
151+
let pathToBuildTools = path.join(this.androidHome, "build-tools");
152+
let buildToolsRange = this.getBuildToolsRange();
153+
buildToolsVersion = this.getMatchingDir(pathToBuildTools, buildToolsRange).wait();
154+
}
151155

152-
return this.getMatchingDir(pathToBuildTools, buildToolsRange).wait();
156+
return buildToolsVersion;
153157
}).future<string>()();
154158
}
155159

@@ -167,9 +171,13 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
167171

168172
private getAndroidSupportLibVersion(): IFuture<string> {
169173
return ((): string => {
170-
let pathToAppCompat = path.join(this.androidHome, "extras", "android", "m2repository", "com", "android", "support", "appcompat-v7");
174+
let selectedAppCompatVersion: string;
171175
let requiredAppCompatRange = this.getAppCompatRange().wait();
172-
let selectedAppCompatVersion = requiredAppCompatRange ? this.getMatchingDir(pathToAppCompat, requiredAppCompatRange).wait() : undefined;
176+
if(this.androidHome && requiredAppCompatRange) {
177+
let pathToAppCompat = path.join(this.androidHome, "extras", "android", "m2repository", "com", "android", "support", "appcompat-v7");
178+
selectedAppCompatVersion = this.getMatchingDir(pathToAppCompat, requiredAppCompatRange).wait();
179+
}
180+
173181
this.$logger.trace(`Selected AppCompat version is: ${selectedAppCompatVersion}`);
174182
return selectedAppCompatVersion;
175183
}).future<string>()();

0 commit comments

Comments
 (0)