Skip to content

Commit 784cf72

Browse files
Merge pull request #4955 from NativeScript/vladimirov/add-missing-await
fix: add missing await for isDynamicFramework check
2 parents 5e15cef + 6d0d77f commit 784cf72

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

lib/services/ios-project-service.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,9 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
233233
const isDynamicFrameworkBundle = async (bundlePath: string) => {
234234
const frameworkBinaryPath = path.join(bundlePath, frameworkName);
235235

236-
return _.includes((await this.$childProcess.spawnFromEvent("file", [frameworkBinaryPath], "close")).stdout, "dynamically linked");
236+
const fileResult = (await this.$childProcess.spawnFromEvent("file", [frameworkBinaryPath], "close")).stdout;
237+
const isDynamicallyLinked = _.includes(fileResult, "dynamically linked");
238+
return isDynamicallyLinked;
237239
};
238240

239241
if (path.extname(frameworkPath) === ".xcframework") {
@@ -249,7 +251,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
249251

250252
return isDynamic;
251253
} else {
252-
return await isDynamicFrameworkBundle(frameworkName);
254+
return await isDynamicFrameworkBundle(frameworkPath);
253255
}
254256
}
255257

@@ -259,7 +261,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
259261

260262
const project = this.createPbxProj(projectData);
261263
const frameworkAddOptions: IXcode.Options = { customFramework: true };
262-
if (this.isDynamicFramework(frameworkPath)) {
264+
if (await this.isDynamicFramework(frameworkPath)) {
263265
frameworkAddOptions["embed"] = true;
264266
}
265267

0 commit comments

Comments
 (0)