Skip to content

Commit 707992a

Browse files
committed
fix: fix "InstallationLookupFailed" error when deploying on iOS device
"InstallationLookupFailed" error is thrown when trying to deploy on iOS device. The reason is that NativeScript CLI is not able to find applicationIdentifier from projectData.projectIdentifiers as the platform is not lower case. For iOS simulator it is fine as the applicationIdentifier is not used when uploading files to the simulator.
1 parent ad08b81 commit 707992a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: lib/controllers/run-controller.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export class RunController implements IRunController {
186186
const deviceDescriptor = _.find(deviceDescriptors, dd => dd.identifier === device.deviceInfo.identifier);
187187
const platformData = this.$platformsDataService.getPlatformData(device.deviceInfo.platform, projectData);
188188
const prepareData = this.$prepareDataService.getPrepareData(liveSyncInfo.projectDir, device.deviceInfo.platform, { ...liveSyncInfo, watch: !liveSyncInfo.skipWatcher, nativePrepare: { skipNativePrepare: !!deviceDescriptor.skipNativePrepare } });
189-
const buildData = this.$buildDataService.getBuildData(projectData.projectDir, device.deviceInfo.platform, { ...liveSyncInfo, outputPath: deviceDescriptor.outputPath });
189+
const buildData = this.$buildDataService.getBuildData(projectData.projectDir, device.deviceInfo.platform, { ...liveSyncInfo, outputPath: deviceDescriptor.outputPath, buildForDevice: !device.isEmulator });
190190
const prepareResultData = await this.$prepareController.prepare(prepareData);
191191

192192
try {

Diff for: lib/services/build-info-file-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class BuildInfoFileService implements IBuildInfoFileService {
5050

5151
public async saveDeviceBuildInfo(device: Mobile.IDevice, projectData: IProjectData, outputFilePath: string): Promise<void> {
5252
const deviceFilePath = await this.getDeviceBuildInfoFilePath(device, projectData);
53-
const appIdentifier = projectData.projectIdentifiers[device.deviceInfo.platform];
53+
const appIdentifier = projectData.projectIdentifiers[device.deviceInfo.platform.toLowerCase()];
5454

5555
await device.fileSystem.putFile(path.join(outputFilePath, buildInfoFileName), deviceFilePath, appIdentifier);
5656
}

0 commit comments

Comments
 (0)