Support xcconfig file from plugin - close #883

Author: jasssonpet

lib/services/ios-project-service.ts

@@ -309,6 +309,10 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 		return path.join(this.platformData.projectRoot, "Podfile");
 	}
 
+	private get projectXcconfigFilePath(): string {
+		return path.join(this.platformData.appDestinationDirectoryPath, "build.xcconfig");
+	}
+
 	private replace(name: string): string {
 		if(_.startsWith(name, '"')) {
 			name = name.substr(1, name.length-2);
@@ -344,6 +348,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 			let pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath(IOSProjectService.IOS_PLATFORM_NAME);
 			this.prepareFrameworks(pluginPlatformsFolderPath, pluginData).wait();
 			this.prepareCocoapods(pluginPlatformsFolderPath, opts).wait();
+			this.prepareXcconfigFile(pluginPlatformsFolderPath).wait();
 		}).future<void>()();
 	}
 
@@ -352,6 +357,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 			let pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath(IOSProjectService.IOS_PLATFORM_NAME);
 			this.removeFrameworks(pluginPlatformsFolderPath, pluginData).wait();
 			this.removeCocoapods(pluginPlatformsFolderPath).wait();
+			this.removeXcconfigFile(pluginPlatformsFolderPath).wait();
 		}).future<void>()();
 	}
 
@@ -405,7 +411,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 
 			let packageType = this.$childProcess.exec(`/usr/libexec/PlistBuddy -c "Print :CFBundlePackageType" "${infoPlistPath}"`).wait().trim();
 			if (packageType !== "FMWK") {
-				this.$errors.failWithoutHelp("The bundle at %s does not appear to be a dynamic framework.", libraryPath);
+				this.$errors.failWithoutHelp("The bundle at %s does not appear to be a framework.", libraryPath);
 			}
 		}).future<void>()();
 	}
@@ -457,6 +463,17 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 		}).future<void>()();
 	}
 
+	private prepareXcconfigFile(pluginPlatformsFolderPath: string): IFuture<void> {
+		return (() => {
+			let pluginXcconfigFilePath = path.join(pluginPlatformsFolderPath, "build.xcconfig");
+			if(this.$fs.exists(pluginXcconfigFilePath).wait()) {
+				let xcconfigContent = this.$fs.readText(pluginXcconfigFilePath).wait();
+				let contentToWrite = this.buildXcconfigContent(pluginXcconfigFilePath, xcconfigContent);
+				this.$fs.appendFile(this.projectXcconfigFilePath, contentToWrite).wait();
+			}
+		}).future<void>()();
+	}
+
 	private removeFrameworks(pluginPlatformsFolderPath: string, pluginData: IPluginData): IFuture<void> {
 		return (() => {
 			let project = this.createPbxProj();
@@ -488,8 +505,25 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 		}).future<void>()();
 	}
 
+	private removeXcconfigFile(pluginPlatformsFolderPath: string): IFuture<void> {
+		return (() => {
+			let pluginXcconfigFilePath = path.join(pluginPlatformsFolderPath, "build.xcconfig");
+			if(this.$fs.exists(pluginXcconfigFilePath).wait()) {
+				let xcconfigContent = this.$fs.readText(pluginXcconfigFilePath).wait();
+				let projectXcconfigFileContent = this.$fs.readText(this.projectXcconfigFilePath).wait();
+				let contentToRemove = this.buildXcconfigContent(pluginXcconfigFilePath, xcconfigContent);
+				projectXcconfigFileContent = helpers.stringReplaceAll(projectXcconfigFileContent, contentToRemove, "");
+				this.$fs.writeFile(this.projectXcconfigFilePath, projectXcconfigFileContent).wait();
+			}
+		}).future<void>()();
+	}
+
 	private buildPodfileContent(pluginPodFilePath: string, pluginPodFileContent: string): string {
 		return `# Begin Podfile - ${pluginPodFilePath} ${os.EOL} ${pluginPodFileContent} ${os.EOL} # End Podfile ${os.EOL}`;
 	}
+
+	private buildXcconfigContent(xcconfigFilePath: string, xcconfigFileContent: string): string {
+		return `${os.EOL}// Begin xcconfig - ${xcconfigFilePath} ${os.EOL} ${xcconfigFileContent} ${os.EOL} // End xcconfig ${os.EOL}`;
+	}
 }
 $injector.register("iOSProjectService", IOSProjectService);