Skip to content

Commit 6cb7cd9

Browse files
committed
The dev webpack does prepare + run, but run always provided bundle: false, and triggered incorrect re-prepare
1 parent 761fc4e commit 6cb7cd9

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

lib/services/livesync/debug-livesync-service.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export class DebugLiveSyncService extends LiveSyncService implements IDebugLiveS
1414
$hooksService: IHooksService,
1515
$pluginsService: IPluginsService,
1616
protected $injector: IInjector,
17-
private $options: IOptions,
17+
$options: IOptions,
1818
private $debugDataService: IDebugDataService,
1919
private $projectData: IProjectData,
2020
private $debugService: IDebugService,
@@ -30,7 +30,8 @@ export class DebugLiveSyncService extends LiveSyncService implements IDebugLiveS
3030
$processService,
3131
$hooksService,
3232
$pluginsService,
33-
$injector);
33+
$injector,
34+
$options);
3435
}
3536

3637
protected async refreshApplication(projectData: IProjectData, liveSyncResultInfo: ILiveSyncResultInfo): Promise<void> {

lib/services/livesync/livesync-service.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ export class LiveSyncService extends EventEmitter implements ILiveSyncService {
2929
private $processService: IProcessService,
3030
private $hooksService: IHooksService,
3131
private $pluginsService: IPluginsService,
32-
protected $injector: IInjector) {
32+
protected $injector: IInjector,
33+
protected $options: IOptions) {
3334
super();
3435
}
3536

@@ -160,8 +161,8 @@ export class LiveSyncService extends EventEmitter implements ILiveSyncService {
160161
options.preparedPlatforms.push(platform);
161162
// TODO: Pass provision and sdk as a fifth argument here
162163
await this.$platformService.preparePlatform(platform, {
163-
bundle: false,
164-
release: false,
164+
bundle: this.$options.bundle,
165+
release: this.$options.release,
165166
}, null, options.projectData, <any>{}, options.modifiedFiles);
166167
}
167168

0 commit comments

Comments
 (0)