Merge pull request #5250 from NativeScript/vladimirov/fix-livesync-externals

fix: external files are not livesynced

Author: rosen-vladimirov

CHANGELOG.md

@@ -1,6 +1,14 @@
 NativeScript CLI Changelog
 ================
 
+6.4.1 (2020, February 19)
+===
+
+### Fixed
+
+* [Fixed #5251](https://github.com/NativeScript/nativescript-cli/issues/5251): External files are not livesynced
+
+
 6.4.0 (2020, February 11)
 ===
 

lib/services/webpack/webpack-compiler-service.ts

@@ -49,11 +49,8 @@ export class WebpackCompilerService extends EventEmitter implements IWebpackComp
 							return;
 						}
 
-						// the hash of the compilation is the same as the previous one
-						if (this.expectedHashes[platformData.platformNameLowerCase] === message.hash) {
-							return;
-						}
-
+						// Persist the previousHash value before calling `this.getUpdatedEmittedFiles` as it will modify the expectedHashes object with the current hash
+						const previousHash = this.expectedHashes[platformData.platformNameLowerCase];
 						let result;
 
 						if (prepareData.hmr) {
@@ -78,6 +75,12 @@ export class WebpackCompilerService extends EventEmitter implements IWebpackComp
 						};
 
 						this.$logger.trace("Generated data from webpack message:", data);
+
+						// the hash of the compilation is the same as the previous one and there are only hot updates produced
+						if (data.hasOnlyHotUpdateFiles && previousHash === message.hash) {
+							return;
+						}
+
 						if (data.files.length) {
 							this.emit(WEBPACK_COMPILATION_COMPLETE, data);
 						}

npm-shrinkwrap.json

@@ -1,7 +1,7 @@
 {
   "name": "nativescript",
   "preferGlobal": true,
-  "version": "6.4.0",
+  "version": "6.4.1",
   "author": "Telerik <[email protected]>",
   "description": "Command-line interface for building NativeScript projects",
   "bin": {