fixed npm install handle peer dependencies case

Author: Plamen5kov

lib/node-package-manager.ts

@@ -25,8 +25,15 @@ export class NodePackageManager implements INodePackageManager {
 		try {
 			let subDirsBefore:Array<string> = this.$fs.exists(path.join(pathToSave, "node_modules")).wait() ? this.$fs.readDirectory(path.join(pathToSave, "node_modules")).wait() : [];
 
-			let flags = this.getFlagsString(config);
-			this.$childProcess.exec(`npm install ${packageName} ${flags}`, { cwd: pathToSave }).wait();
+			let flags = this.getFlagsString(config, true);
+			let params = ["install", packageName];
+			for(let index in flags) {
+				params.push(flags[index]);
+			}
+			let res = this.$childProcess.spawnFromEvent("npm", params, "close", {}, { throwError: false }).wait();
+			if(res.stderr) {
+				throw {stderr: res.stderr};
+			}
 
 			let subDirsAfter = this.$fs.readDirectory(path.join(pathToSave, "node_modules")).wait();
 
@@ -43,7 +50,7 @@ export class NodePackageManager implements INodePackageManager {
 
 			return diff;
 		} catch (err) {
-			if (err.code === "EPEERINVALID" || err.code === 1) {
+			if (err.stderr && err.stderr.indexOf("EPEERINVALID") !== -1) {
 				// Not installed peer dependencies are treated by npm 2 as errors, but npm 3 treats them as warnings.
 				// We'll show them as warnings and let the user install them in case they are needed.
 				// The strucutre of the error object in such case is:
@@ -63,7 +70,7 @@ export class NodePackageManager implements INodePackageManager {
 				//      '@ngrx/[email protected]': '^2.0.0',
 				//      '@ngrx/[email protected]': '^2.0.0',
 				//      '[email protected]': '~2.0.0' } }
-				this.$logger.warn(err.message);
+				this.$logger.warn(err.stderr);
 			} else {
 				// All other errors should be handled by the caller code.
 				throw err;
@@ -72,7 +79,7 @@ export class NodePackageManager implements INodePackageManager {
 	}
 
 	public uninstall(packageName: string, config?: any, path?: string): IFuture<any> {
-		let flags = this.getFlagsString(config);
+		let flags = this.getFlagsString(config, false);
 		return this.$childProcess.exec(`npm uninstall ${packageName} ${flags}`, { cwd: path });
 	}
 
@@ -82,23 +89,27 @@ export class NodePackageManager implements INodePackageManager {
 	}
 
 	public view(packageName: string, config: any): IFuture<any> {
-		let flags = this.getFlagsString(config);
+		let flags = this.getFlagsString(config, false);
 		let viewResult = this.$childProcess.exec(`npm view ${packageName} ${flags}`).wait();
 		return JSON.parse(viewResult);
 	}
 
-	private getFlagsString(config: any) : string{
-		let flagsString = "";
+	private getFlagsString(config: any, asArray: boolean) : any{
+		let array:Array<string> = [];
 		for(let flag in config) {
 			if(config[flag]) {
 				if(flag==="dist-tags" || flag==="versions") {
-					flagsString += ` ${flag}`;
+					array.push(` ${flag}`)
 					continue;
 				}
-				flagsString += ` --${flag}`;
+				array.push(`--${flag}`)
 			}
 		}
-		return flagsString;
+		if(asArray) {
+			return array;
+		}
+
+		return array.join(" ");
 	}
 }
 $injector.register("npm", NodePackageManager);