Skip to content

Commit 6684a3e

Browse files
authored
feat(android): allow modifying gradlew args in hooks (#5301)
1 parent 7e45718 commit 6684a3e

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

lib/services/android/gradle-build-args-service.ts

+4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { Configurations } from "../../common/constants";
33

44
export class GradleBuildArgsService implements IGradleBuildArgsService {
55
constructor(private $androidToolsInfo: IAndroidToolsInfo,
6+
private $hooksService: IHooksService,
67
private $analyticsService: IAnalyticsService,
78
private $staticConfig: Config.IStaticConfig,
89
private $logger: ILogger) { }
@@ -15,6 +16,9 @@ export class GradleBuildArgsService implements IGradleBuildArgsService {
1516
args.push("-PgatherAnalyticsData=true");
1617
}
1718

19+
// allow modifying gradle args from a `before-build-task-args` hook
20+
await this.$hooksService.executeBeforeHooks('build-task-args', { hookArgs: { args } });
21+
1822
return args;
1923
}
2024

test/services/android/gradle-build-args-service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ function createTestInjector(): IInjector {
1616
})
1717
});
1818
injector.register("logger", {});
19+
injector.register("hooksService", stubs.HooksServiceStub);
1920
injector.register("gradleBuildArgsService", GradleBuildArgsService);
2021
injector.register("analyticsService", stubs.AnalyticsService);
2122
injector.register("staticConfig", {TRACK_FEATURE_USAGE_SETTING_NAME: "TrackFeatureUsage"});

0 commit comments

Comments
 (0)