Skip to content

Commit 636d619

Browse files
committed
refactor(preview): rename method generateQrCode to printLiveSyncQrCode
1 parent 34aead2 commit 636d619

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

lib/commands/preview.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export class PreviewCommand implements ICommand {
2424
useHotModuleReload: this.$options.hmr
2525
});
2626

27-
await this.$previewQrCodeService.generateQrCode({ useHotModuleReload: this.$options.hmr, link: this.$options.link });
27+
await this.$previewQrCodeService.printLiveSyncQrCode({ useHotModuleReload: this.$options.hmr, link: this.$options.link });
2828
}
2929

3030
public async canExecute(args: string[]): Promise<boolean> {

lib/definitions/preview-app-livesync.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ declare global {
2323
}
2424

2525
interface IPreviewQrCodeService {
26-
generateQrCode(options: IGenerateQrCodeOptions): Promise<void>;
26+
printLiveSyncQrCode(options: IGenerateQrCodeOptions): Promise<void>;
2727
}
2828

2929
interface IGenerateQrCodeOptions extends IHasUseHotModuleReloadOption {

lib/services/livesync/playground/preview-qr-code-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export class PreviewQrCodeService implements IPreviewQrCodeService {
1010
private $logger: ILogger) {
1111
}
1212

13-
public async generateQrCode(options: IGenerateQrCodeOptions): Promise<void> {
13+
public async printLiveSyncQrCode(options: IGenerateQrCodeOptions): Promise<void> {
1414
let url = this.$previewSdkService.getQrCodeUrl(options);
1515
const shortenUrlEndpoint = util.format(this.$config.SHORTEN_URL_ENDPOINT, encodeURIComponent(url));
1616
try {

lib/services/platform-environment-requirements.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ export class PlatformEnvironmentRequirements implements IPlatformEnvironmentRequ
194194
useHotModuleReload: options.hmr
195195
});
196196

197-
await this.$previewQrCodeService.generateQrCode({ useHotModuleReload: options.hmr, link: options.link });
197+
await this.$previewQrCodeService.printLiveSyncQrCode({ useHotModuleReload: options.hmr, link: options.link });
198198
}
199199
}
200200

0 commit comments

Comments
 (0)