Skip to content

Commit 598d079

Browse files
committed
Code review improvements
1 parent 29a5190 commit 598d079

File tree

1 file changed

+17
-21
lines changed

1 file changed

+17
-21
lines changed

lib/services/platform-service.ts

+17-21
Original file line numberDiff line numberDiff line change
@@ -7,31 +7,27 @@ import constants = require("./../constants");
77
import helpers = require("./../common/helpers");
88

99
class PlatformsData implements IPlatformsData {
10-
private platformsData = {
11-
ios: {
12-
frameworkPackageName: "tns-ios",
13-
platformProjectService: null,
14-
normalizedPlatformName: "iOS",
15-
projectRoot: "",
16-
targetedOS: ['darwin']
17-
},
18-
android: {
19-
frameworkPackageName: "tns-android",
20-
platformProjectService: null,
21-
normalizedPlatformName: "Android",
22-
projectRoot: ""
23-
}
24-
};
10+
private platformsData = {};
2511

2612
constructor($projectData: IProjectData,
2713
$androidProjectService: IPlatformProjectService,
2814
$iOSProjectService: IPlatformProjectService) {
2915

30-
this.platformsData.ios.projectRoot = "";
31-
this.platformsData.ios.platformProjectService = $iOSProjectService;
32-
33-
this.platformsData.android.projectRoot = path.join($projectData.platformsDir, "android");
34-
this.platformsData.android.platformProjectService = $androidProjectService;
16+
this.platformsData = {
17+
ios: {
18+
frameworkPackageName: "tns-ios",
19+
normalizedPlatformName: "iOS",
20+
platformProjectService: $iOSProjectService,
21+
projectRoot: "",
22+
targetedOS: ['darwin']
23+
},
24+
android: {
25+
frameworkPackageName: "tns-android",
26+
normalizedPlatformName: "Android",
27+
platformProjectService: $androidProjectService,
28+
projectRoot: path.join($projectData.platformsDir, "android")
29+
}
30+
}
3531
}
3632

3733
public get platformsNames() {
@@ -108,7 +104,7 @@ export class PlatformService implements IPlatformService {
108104
platformProjectService.createProject(platformData.projectRoot, frameworkDir).wait();
109105

110106
// Need to remove unneeded node_modules folder
111-
this.$fs.deleteDirectory(path.join(this.$projectData.platformsDir, platform, "node_modules")).wait();
107+
this.$fs.deleteDirectory(path.join("../", frameworkDir)).wait();
112108

113109
platformProjectService.interpolateData(platformData.projectRoot);
114110
platformProjectService.afterCreateProject(platformData.projectRoot);

0 commit comments

Comments
 (0)