Skip to content

Commit 57ac858

Browse files
committed
chore: fix PR comments
1 parent 187ebf3 commit 57ac858

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

Gruntfile.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ module.exports = function (grunt) {
243243

244244
function registerTestingDependenciesTasks(grunt) {
245245
const configsBasePath = path.join(__dirname, "config");
246-
const generatedVersionFileName = "test-deps-versions-generated.json";
246+
const generatedVersionFilePath = path.join(configsBasePath, "test-deps-versions-generated.json");
247247

248248
grunt.registerTask("generate_unit_testing_dependencies", async function () {
249249
var done = this.async();
@@ -253,12 +253,12 @@ function registerTestingDependenciesTasks(grunt) {
253253
const dependencyVersion = dependency.version || await latestVersion(dependency.name);
254254
dependenciesVersions[dependency.name] = dependencyVersion;
255255
}
256-
grunt.file.write(path.join(configsBasePath, generatedVersionFileName), JSON.stringify(dependenciesVersions));
256+
grunt.file.write(generatedVersionFilePath, JSON.stringify(dependenciesVersions));
257257
done();
258258
});
259259

260260
grunt.registerTask("verify_unit_testing_dependencies", function () {
261-
if (!grunt.file.exists(path.join(configsBasePath, generatedVersionFileName))) {
261+
if (!grunt.file.exists(generatedVersionFilePath)) {
262262
throw new Error("Unit testing dependencies are not configured.");
263263
}
264264
});

config/test-dependencies.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"name": "karma-nativescript-launcher"
77
},
88
{
9-
"name": "karma-jasmine",
10-
"framework": "jasmine"
9+
"name": "mocha",
10+
"framework": "mocha"
1111
},
1212
{
1313
"name": "karma-mocha",
@@ -18,8 +18,8 @@
1818
"framework": "mocha"
1919
},
2020
{
21-
"name": "mocha",
22-
"framework": "mocha"
21+
"name": "karma-jasmine",
22+
"framework": "jasmine"
2323
},
2424
{
2525
"name": "karma-qunit",

lib/definitions/project.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -476,8 +476,8 @@ interface ITestExecutionService {
476476
}
477477

478478
interface ITestInitializationService {
479-
getDependencies(framework: string): string[]
480-
getDependenciesVersions(): IDictionary<string>
479+
getDependencies(framework: string): string[];
480+
getDependenciesVersions(): IDictionary<string>;
481481
}
482482

483483
/**

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
"grunt-template": "1.0.0",
121121
"grunt-ts": "6.0.0-beta.16",
122122
"istanbul": "0.4.5",
123-
"latest-version": "^4.0.0",
123+
"latest-version": "4.0.0",
124124
"mocha": "3.1.2",
125125
"should": "7.0.2",
126126
"sinon": "4.1.2",

0 commit comments

Comments
 (0)