feat: support hmr in preview

Author: DimitarTachev

lib/commands/preview.ts

@@ -22,7 +22,7 @@ export class PreviewCommand implements ICommand {
 			timeout: this.$options.timeout
 		});
 
-		await this.$playgroundQrCodeGenerator.generateQrCodeForCurrentApp();
+		await this.$playgroundQrCodeGenerator.generateQrCodeForCurrentApp(this.$options.hmr);
 	}
 
 	public async canExecute(args: string[]): Promise<boolean> {

lib/definitions/preview-app-livesync.d.ts

@@ -10,7 +10,7 @@ declare global {
 	interface IPreviewAppLiveSyncData extends IProjectDir, IAppFilesUpdaterOptionsComposition, IEnvOptions { }
 
 	interface IPreviewSdkService {
-		qrCodeUrl: string;
+		getQrCodeUrl(options: { useHmr: boolean }): string;
 		connectedDevices: Device[];
 		initialize(getInitialFiles: (device: Device) => Promise<FilesPayload>): void;
 		applyChanges(filesPayload: FilesPayload): Promise<void>;
@@ -29,6 +29,6 @@ declare global {
 	interface IPlaygroundQrCodeGenerator {
 		generateQrCodeForiOS(): Promise<void>;
 		generateQrCodeForAndroid(): Promise<void>;
-		generateQrCodeForCurrentApp(): Promise<void>;
+		generateQrCodeForCurrentApp(useHmr: boolean): Promise<void>;
 	}
 }

lib/helpers/preview-command-helper.ts

@@ -6,6 +6,7 @@ export class PreviewCommandHelper implements IPreviewCommandHelper {
 	private ctrlcReader: readline.ReadLine;
 
 	constructor(private $playgroundQrCodeGenerator: IPlaygroundQrCodeGenerator,
+		private $options: IOptions,
 		private $processService: IProcessService) {
 			this.$processService.attachToProcessExitSignals(this, () => {
 				this.stopWaitingForCommand();
@@ -49,7 +50,7 @@ export class PreviewCommandHelper implements IPreviewCommandHelper {
 				await this.$playgroundQrCodeGenerator.generateQrCodeForiOS();
 				return;
 			case "c":
-				await this.$playgroundQrCodeGenerator.generateQrCodeForCurrentApp();
+				await this.$playgroundQrCodeGenerator.generateQrCodeForCurrentApp(this.$options.hmr);
 				return;
 		}
 	}

lib/services/livesync/playground/preview-sdk-service.ts

@@ -13,8 +13,9 @@ export class PreviewSdkService implements IPreviewSdkService {
 		private $config: IConfiguration) {
 	}
 
-	public get qrCodeUrl(): string {
-		return `nsplay://boot?instanceId=${this.instanceId}&pKey=${PubnubKeys.PUBLISH_KEY}&sKey=${PubnubKeys.SUBSCRIBE_KEY}&template=play-ng`;
+	public getQrCodeUrl(options: { useHmr: boolean }): string {
+		const hmrValue = options.useHmr ? "1" : "0";
+		return `nsplay://boot?instanceId=${this.instanceId}&pKey=${PubnubKeys.PUBLISH_KEY}&sKey=${PubnubKeys.SUBSCRIBE_KEY}&template=play-ng&hmr=${hmrValue}`;
 	}
 
 	public initialize(getInitialFiles: (device: Device) => Promise<FilesPayload>): void {

lib/services/livesync/playground/qr-code-generator.ts

@@ -18,8 +18,8 @@ export class PlaygroundQrCodeGenerator implements IPlaygroundQrCodeGenerator {
 		await this.generateQrCode(PlaygroundStoreUrls.GOOGLE_PLAY_URL);
 	}
 
-	public async generateQrCodeForCurrentApp(): Promise<void> {
-		await this.generateQrCode(this.$previewSdkService.qrCodeUrl);
+	public async generateQrCodeForCurrentApp(useHmr: boolean): Promise<void> {
+		await this.generateQrCode(this.$previewSdkService.getQrCodeUrl(useHmr));
 	}
 
 	private async generateQrCode(url: string): Promise<void> {

test/helpers/preview-command-helper.ts

@@ -26,7 +26,7 @@ function createTestInjector() {
 		generateQrCodeForiOS: async () => {
 			qrCodesData.isGeneratedForiOS = true;
 		},
-		generateQrCodeForCurrentApp: async () => {
+		generateQrCodeForCurrentApp: async (useHmr: boolean) => {
 			qrCodesData.isGeneratedForCurrentApp = true;
 		}
 	});

test/services/playground/preview-app-livesync-service.ts

@@ -65,7 +65,7 @@ const syncFilesMockData = {
 class PreviewSdkServiceMock implements IPreviewSdkService {
 	public getInitialFiles: (device: Device) => Promise<FilesPayload>;
 
-	public get qrCodeUrl() {
+	public getQrCodeUrl(options: { useHmr: boolean }) {
 		return "my_cool_qr_code_url";
 	}