Skip to content

Commit 4f790da

Browse files
committed
Fast livesync for images in app folder
1 parent bb223dc commit 4f790da

File tree

6 files changed

+11
-7
lines changed

6 files changed

+11
-7
lines changed

lib/definitions/platform.d.ts

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ interface IPlatformData {
4040
configurationFilePath?: string;
4141
relativeToFrameworkConfigurationFilePath: string;
4242
mergeXmlConfig?: any[];
43+
fastLivesyncFileExtensions: string[];
4344
}
4445

4546
interface IPlatformsData {

lib/services/android-project-service.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
5656
configurationFileName: "AndroidManifest.xml",
5757
configurationFilePath: path.join(projectRoot, "src", "main", "AndroidManifest.xml"),
5858
relativeToFrameworkConfigurationFilePath: path.join("src", "main", "AndroidManifest.xml"),
59-
mergeXmlConfig: [{ "nodename": "manifest", "attrname": "*" }, {"nodename": "application", "attrname": "*"}]
59+
mergeXmlConfig: [{ "nodename": "manifest", "attrname": "*" }, {"nodename": "application", "attrname": "*"}],
60+
fastLivesyncFileExtensions: [".jpg", ".gif", ".png", ".bmp", ".webp"] // http://developer.android.com/guide/appendix/media-formats.html
6061
};
6162
}
6263

lib/services/ios-project-service.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
6464
configurationFileName: "Info.plist",
6565
configurationFilePath: path.join(projectRoot, this.$projectData.projectName, this.$projectData.projectName+"-Info.plist"),
6666
relativeToFrameworkConfigurationFilePath: path.join("__PROJECT_NAME__", "__PROJECT_NAME__-Info.plist"),
67-
mergeXmlConfig: [{ "nodename": "plist", "attrname": "*" }, {"nodename": "dict", "attrname": "*"}]
67+
mergeXmlConfig: [{ "nodename": "plist", "attrname": "*" }, {"nodename": "dict", "attrname": "*"}],
68+
fastLivesyncFileExtensions: [".tiff", ".tif", ".jpg", "jpeg", "gif", ".png", ".bmp", ".BMPf", ".ico", ".cur", ".xbm"] // https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIImage_Class/
6869
};
6970
}
7071

lib/services/usb-livesync-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export class UsbLiveSyncService extends usbLivesyncServiceBaseLib.UsbLiveSyncSer
120120

121121
let localProjectRootPath = platform.toLowerCase() === "ios" ? platformData.appDestinationDirectoryPath : null;
122122

123-
let fastLivesyncFileExtensions = [".css", ".xml"];
123+
let fastLivesyncFileExtensions = [".css", ".xml"].concat(platformData.fastLivesyncFileExtensions);
124124

125125
let fastLiveSync = (filePath: string) => {
126126
this.$dispatcher.dispatch(() => {

test/platform-commands.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ class PlatformData implements IPlatformData {
2525
deviceBuildOutputPath = "";
2626
validPackageNamesForDevice: string[] = [];
2727
frameworkFilesExtensions = [".jar", ".dat"];
28-
frameworkVersion = "";
2928
appDestinationDirectoryPath = "";
30-
appResourcesDestinationDirectoryPath = "";
3129
relativeToFrameworkConfigurationFilePath = "";
30+
fastLivesyncFileExtensions: string[] = [];
3231
}
3332

3433
class ErrorsNoFailStub implements IErrors {

test/stubs.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,8 @@ export class PlatformsDataStub implements IPlatformsData {
268268
deviceBuildOutputPath: "",
269269
validPackageNamesForDevice: [],
270270
frameworkFilesExtensions: [],
271-
relativeToFrameworkConfigurationFilePath: ""
271+
relativeToFrameworkConfigurationFilePath: "",
272+
fastLivesyncFileExtensions: []
272273
};
273274
}
274275

@@ -289,7 +290,8 @@ export class PlatformProjectServiceStub implements IPlatformProjectService {
289290
validPackageNamesForDevice: [],
290291
frameworkFilesExtensions: [],
291292
appDestinationDirectoryPath: "",
292-
relativeToFrameworkConfigurationFilePath: ""
293+
relativeToFrameworkConfigurationFilePath: "",
294+
fastLivesyncFileExtensions: []
293295
};
294296
}
295297
getAppResourcesDestinationDirectoryPath(): IFuture<string>{

0 commit comments

Comments
 (0)