Skip to content

Commit 3f37209

Browse files
authored
Merge pull request #5041 from NativeScript/fatme/merge-release-master
chore: merge release into master
2 parents 033032a + 219d214 commit 3f37209

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

docs/man_pages/project/creation/create.md

+1
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ Template | Command
5353
`Angular - Tabs` | tns create --template tns-template-tab-navigation-ng
5454
`Vue.js - Blank`, `--vue`, `--vuejs` | tns create --template tns-template-blank-vue
5555
`Vue.js - SideDrawer`, | tns create --template tns-template-drawer-navigation-vue
56+
`Vue.js - Tabs` | tns create --template tns-template-tab-navigation-vue
5657

5758
### Related Commands
5859

lib/commands/create-project.ts

+5
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,11 @@ or --js flags.)
210210
key: CreateProjectCommand.DrawerTemplateKey,
211211
value: "tns-template-drawer-navigation-vue",
212212
description: CreateProjectCommand.DrawerTemplateDescription
213+
},
214+
{
215+
key: CreateProjectCommand.TabsTemplateKey,
216+
value: "tns-template-tab-navigation-vue",
217+
description: CreateProjectCommand.TabsTemplateDescription
213218
}];
214219

215220
return templates;

lib/common/test/unit-tests/logger.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,14 @@ describe("logger", () => {
162162
[undefined, null, false, "string value", 42, { obj: 1 }, ["string value 1", "string value 2"]].forEach(value => {
163163
it(`handles formatted message with '${value}' value in one of the args`, () => {
164164
logger.info("test %s", value);
165-
assert.equal(outputs.info, `test ${value}`);
165+
assert.equal(outputs.info, util.format("test %s", value));
166166
assert.deepEqual(outputs.context, {}, "Nothing should be added to logger context.");
167167
assert.deepEqual(outputs.removedContext, {}, "Removed context should be empty.");
168168
});
169169

170170
it(`handles formatted message with '${value}' value in one of the args and additional values passed to context`, () => {
171171
logger.info("test %s", value, { [LoggerConfigData.skipNewLine]: true });
172-
assert.equal(outputs.info, `test ${value}`);
172+
assert.equal(outputs.info, util.format("test %s", value));
173173
assert.deepEqual(outputs.context, { [LoggerConfigData.skipNewLine]: true }, `${LoggerConfigData.skipNewLine} should be set with value true.`);
174174
assert.deepEqual(outputs.removedContext, { [LoggerConfigData.skipNewLine]: true }, `Removed context should contain ${LoggerConfigData.skipNewLine}`);
175175
});

test/project-commands.ts

+8-9
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,14 @@ const expectedFlavorChoices = [
1818
{ key: "Plain TypeScript", description: "Learn more at https://nativescript.org/typescript" },
1919
{ key: "Plain JavaScript", description: "Use NativeScript without any framework" }
2020
];
21-
const expectedTemplateChoices = [
22-
{ key: "Hello World", description: "A Hello World app" },
23-
{ key: "SideDrawer", description: "An app with pre-built pages that uses a drawer for navigation" },
24-
{ key: "Tabs", description: "An app with pre-built pages that uses tabs for navigation" }
25-
];
26-
const expectedTemplateChoicesVue = [
27-
{ key: "Blank", description: "A blank app" },
28-
{ key: "SideDrawer", description: "An app with pre-built pages that uses a drawer for navigation" }
29-
];
21+
const templateChoises = {
22+
helloWorld: { key: "Hello World", description: "A Hello World app" },
23+
blank: { key: "Blank", description: "A blank app" },
24+
sideDrawer: { key: "SideDrawer", description: "An app with pre-built pages that uses a drawer for navigation" },
25+
tabs: { key: "Tabs", description: "An app with pre-built pages that uses tabs for navigation" }
26+
};
27+
const expectedTemplateChoices = [templateChoises.helloWorld, templateChoises.sideDrawer, templateChoises.tabs];
28+
const expectedTemplateChoicesVue = [templateChoises.blank, templateChoises.sideDrawer, templateChoises.tabs];
3029

3130
class ProjectServiceMock implements IProjectService {
3231
async validateProjectName(opts: { projectName: string, force: boolean, pathToProject: string }): Promise<string> {

0 commit comments

Comments
 (0)