Merge pull request #3906 from NativeScript/fatme/network-validator

chore: check network connectivity when `tns preview` command is executed

Author: Fatme

lib/bootstrap.ts

@@ -181,3 +181,5 @@ $injector.require("iOSDebuggerPortService", "./services/ios-debugger-port-servic
 
 $injector.require("pacoteService", "./services/pacote-service");
 $injector.require("qrCodeTerminalService", "./services/qr-code-terminal-service");
+
+$injector.require("networkConnectivityValidator", "./helpers/network-connectivity-validator");

lib/commands/preview.ts

@@ -3,6 +3,7 @@ export class PreviewCommand implements ICommand {
 
 	constructor(private $bundleValidatorHelper: IBundleValidatorHelper,
 		private $liveSyncService: ILiveSyncService,
+		private $networkConnectivityValidator: INetworkConnectivityValidator,
 		private $projectData: IProjectData,
 		private $options: IOptions,
 		private $playgroundQrCodeGenerator: IPlaygroundQrCodeGenerator,
@@ -27,6 +28,7 @@ export class PreviewCommand implements ICommand {
 	}
 
 	public async canExecute(args: string[]): Promise<boolean> {
+		await this.$networkConnectivityValidator.validate();
 		this.$bundleValidatorHelper.validate();
 		return true;
 	}

lib/declarations.d.ts

@@ -865,4 +865,8 @@ interface IAssetsGenerationService {
 interface IRuntimeGradleVersions {
 	gradleVersion?: string;
 	gradleAndroidPluginVersion?: string;
+}
+
+interface INetworkConnectivityValidator {
+	validate(): Promise<void>;
 }

lib/helpers/network-connectivity-validator.ts

@@ -0,0 +1,31 @@
+import * as dns from "dns";
+
+export class NetworkConnectivityValidator implements INetworkConnectivityValidator {
+	private static DNS_LOOKUP_URL = "play.nativescript.org";
+	private static NO_INTERNET_ERROR_CODE = "ENOTFOUND";
+	private static NO_INTERNET_ERROR_MESSAGE = "No internet connection. Check your internet settings and try again.";
+
+	constructor(private $errors: IErrors,
+		private $logger: ILogger) { }
+
+	public async validate(): Promise<void> {
+		const isConnected = await this.isConnected();
+		if (!isConnected) {
+			this.$errors.failWithoutHelp(NetworkConnectivityValidator.NO_INTERNET_ERROR_MESSAGE);
+		}
+	}
+
+	private isConnected(): Promise<boolean> {
+		return new Promise((resolve, reject) => {
+			dns.lookup(NetworkConnectivityValidator.DNS_LOOKUP_URL, err => {
+				this.$logger.trace(`Error from dns.lookup is ${err}.`);
+				if (err && err.code === NetworkConnectivityValidator.NO_INTERNET_ERROR_CODE) {
+					resolve(false);
+				} else {
+					resolve(true);
+				}
+			});
+		});
+	}
+}
+$injector.register("networkConnectivityValidator", NetworkConnectivityValidator);