Skip to content

Commit 353a18d

Browse files
fix: add missing await for isDynamicFramework check
There's a missing await in the check if an iOS Framework is dynamic. Linter rule (no-floating-promises) does not catch it, as it is not a pure call, i.e. linter will fail in case the code is: ``` this.isDynamicFramework(frameworkPath); ``` But it will not fail in case the method is called inside if statement (as it is in our code) or when you assing the value to a variable and do not await it anywhere: ``` const isDynamic = this.isDynamicFramework(frameworkPath); ```
1 parent 83b9c34 commit 353a18d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/services/ios-project-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
259259

260260
const project = this.createPbxProj(projectData);
261261
const frameworkAddOptions: IXcode.Options = { customFramework: true };
262-
if (this.isDynamicFramework(frameworkPath)) {
262+
if (await this.isDynamicFramework(frameworkPath)) {
263263
frameworkAddOptions["embed"] = true;
264264
}
265265

0 commit comments

Comments
 (0)