Skip to content

Commit 2f24064

Browse files
Use correct .apk name
Gradle uses the third part of the identifier for apk name. Currently we are checking for projectName (created from dir name). Check both of them when searching for apk. Fixes #1041
1 parent 01f651d commit 2f24064

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

lib/services/android-project-service.ts

+8-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
3737
public get platformData(): IPlatformData {
3838
if (!this._platformData) {
3939
let projectRoot = path.join(this.$projectData.platformsDir, "android");
40-
40+
let packageName = this.getProjectNameFromId();
4141
this._platformData = {
4242
frameworkPackageName: "tns-android",
4343
normalizedPlatformName: "Android",
@@ -47,6 +47,8 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
4747
projectRoot: projectRoot,
4848
deviceBuildOutputPath: path.join(projectRoot, "build", "outputs", "apk"),
4949
validPackageNamesForDevice: [
50+
`${packageName}-debug.apk`,
51+
`${packageName}-release.apk`,
5052
`${this.$projectData.projectName}-debug.apk`,
5153
`${this.$projectData.projectName}-release.apk`
5254
],
@@ -141,11 +143,15 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
141143
shell.sed('-i', /__TITLE_ACTIVITY__/, this.$projectData.projectName, stringsFilePath);
142144

143145
let gradleSettingsFilePath = path.join(this.platformData.projectRoot, "settings.gradle");
144-
shell.sed('-i', /__PROJECT_NAME__/, this.$projectData.projectId.split(".")[2], gradleSettingsFilePath);
146+
shell.sed('-i', /__PROJECT_NAME__/, this.getProjectNameFromId(), gradleSettingsFilePath);
145147
shell.sed('-i', /__APILEVEL__/, this.$options.sdk || this.$androidToolsInfo.getToolsInfo().wait().compileSdkVersion.toString(), manifestPath);
146148
}).future<void>()();
147149
}
148150

151+
private getProjectNameFromId(): string {
152+
return this.$projectData.projectId.split(".")[2];
153+
}
154+
149155
public afterCreateProject(projectRoot: string): IFuture<void> {
150156
return Future.fromResult();
151157
}

0 commit comments

Comments
 (0)