fix: handle disposing of cleanup-process

Currently the cleanup-process is never disconnected from CLI as in the `commandsService` we set the `shouldDispose` property to false. This breaks short living commands like `tns create`, `tns devices`, etc.
Handle the disposing similar to the other long living commands in CLI.

Author: rosen-vladimirov

lib/commands/debug.ts

@@ -91,14 +91,16 @@ export class DebugIOSCommand implements ICommand {
 		private $sysInfo: ISysInfo,
 		private $projectData: IProjectData,
 		$iosDeviceOperations: IIOSDeviceOperations,
-		$iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider) {
+		$iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider,
+		$cleanupService: ICleanupService) {
 		this.$projectData.initializeProjectData();
 		// Do not dispose ios-device-lib, so the process will remain alive and the debug application (NativeScript Inspector or Chrome DevTools) will be able to connect to the socket.
 		// In case we dispose ios-device-lib, the socket will be closed and the code will fail when the debug application tries to read/send data to device socket.
 		// That's why the `$ tns debug ios --justlaunch` command will not release the terminal.
 		// In case we do not set it to false, the dispose will be called once the command finishes its execution, which will prevent the debugging.
 		$iosDeviceOperations.setShouldDispose(false);
 		$iOSSimulatorLogProvider.setShouldDispose(false);
+		$cleanupService.setShouldDispose(false);
 	}
 
 	public execute(args: string[]): Promise<void> {

lib/commands/preview.ts

@@ -13,8 +13,10 @@ export class PreviewCommand implements ICommand {
 		private $projectData: IProjectData,
 		private $options: IOptions,
 		private $previewAppLogProvider: IPreviewAppLogProvider,
-		private $previewQrCodeService: IPreviewQrCodeService) {
-			this.$analyticsService.setShouldDispose(this.$options.justlaunch || !this.$options.watch);
+		private $previewQrCodeService: IPreviewQrCodeService,
+		$cleanupService: ICleanupService) {
+			this.$analyticsService.setShouldDispose(false);
+			$cleanupService.setShouldDispose(false);
 		}
 
 	public async execute(): Promise<void> {

lib/commands/test.ts

@@ -10,6 +10,7 @@ abstract class TestCommandBase {
 	protected abstract $options: IOptions;
 	protected abstract $platformEnvironmentRequirements: IPlatformEnvironmentRequirements;
 	protected abstract $errors: IErrors;
+	protected abstract $cleanupService: ICleanupService;
 
 	async execute(args: string[]): Promise<void> {
 		await this.$testExecutionService.startKarmaServer(this.platform, this.$projectData, this.projectFilesConfig);
@@ -18,6 +19,7 @@ abstract class TestCommandBase {
 	async canExecute(args: string[]): Promise<boolean | ICanExecuteCommandOutput> {
 		this.$projectData.initializeProjectData();
 		this.$analyticsService.setShouldDispose(this.$options.justlaunch || !this.$options.watch);
+		this.$cleanupService.setShouldDispose(this.$options.justlaunch || !this.$options.watch);
 		this.projectFilesConfig = helpers.getProjectFilesConfig({ isReleaseBuild: this.$options.release });
 
 		const output = await this.$platformEnvironmentRequirements.checkEnvironmentRequirements({
@@ -51,7 +53,8 @@ class TestAndroidCommand extends TestCommandBase implements ICommand {
 		protected $analyticsService: IAnalyticsService,
 		protected $options: IOptions,
 		protected $platformEnvironmentRequirements: IPlatformEnvironmentRequirements,
-		protected $errors: IErrors) {
+		protected $errors: IErrors,
+		protected $cleanupService: ICleanupService) {
 		super();
 	}
 
@@ -65,7 +68,8 @@ class TestIosCommand extends TestCommandBase implements ICommand {
 		protected $analyticsService: IAnalyticsService,
 		protected $options: IOptions,
 		protected $platformEnvironmentRequirements: IPlatformEnvironmentRequirements,
-		protected $errors: IErrors) {
+		protected $errors: IErrors,
+		protected $cleanupService: ICleanupService) {
 		super();
 	}
 

lib/common/commands/device/device-log-stream.ts

@@ -7,8 +7,10 @@ export class OpenDeviceLogStreamCommand implements ICommand {
 		private $options: IOptions,
 		private $deviceLogProvider: Mobile.IDeviceLogProvider,
 		private $loggingLevels: Mobile.ILoggingLevels,
-		$iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider) {
+		$iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider,
+		$cleanupService: ICleanupService) {
 			$iOSSimulatorLogProvider.setShouldDispose(false);
+			$cleanupService.setShouldDispose(false);
 		}
 
 	allowedParameters: ICommandParameter[] = [];

lib/common/services/commands-service.ts

@@ -28,8 +28,7 @@ export class CommandsService implements ICommandsService {
 		private $helpService: IHelpService,
 		private $extensibilityService: IExtensibilityService,
 		private $optionsTracker: IOptionsTracker,
-		private $projectDataService: IProjectDataService,
-		private $cleanupService: ICleanupService) {
+		private $projectDataService: IProjectDataService) {
 			let projectData = null;
 			try {
 				projectData = this.$projectDataService.getProjectData();
@@ -38,7 +37,6 @@ export class CommandsService implements ICommandsService {
 			}
 
 			this.$options.setupOptions(projectData);
-			this.$cleanupService.setShouldDispose(this.$options.justlaunch || !this.$options.watch);
 	}
 
 	public allCommands(opts: { includeDevCommands: boolean }): string[] {

lib/helpers/livesync-command-helper.ts

@@ -15,8 +15,8 @@ export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {
 		private $bundleValidatorHelper: IBundleValidatorHelper,
 		private $errors: IErrors,
 		private $iOSSimulatorLogProvider: Mobile.IiOSSimulatorLogProvider,
-		private $logger: ILogger) {
-		this.$analyticsService.setShouldDispose(this.$options.justlaunch || !this.$options.watch);
+		private $logger: ILogger,
+		private $cleanupService: ICleanupService) {
 	}
 
 	public getPlatformsForOperation(platform: string): string[] {
@@ -59,9 +59,14 @@ export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {
 
 		const workingWithiOSDevices = !platform || this.$mobileHelper.isiOSPlatform(platform);
 		const shouldKeepProcessAlive = this.$options.watch || !this.$options.justlaunch;
-		if (workingWithiOSDevices && shouldKeepProcessAlive) {
-			this.$iosDeviceOperations.setShouldDispose(false);
-			this.$iOSSimulatorLogProvider.setShouldDispose(false);
+		if (shouldKeepProcessAlive) {
+			this.$analyticsService.setShouldDispose(false);
+			this.$cleanupService.setShouldDispose(false);
+
+			if (workingWithiOSDevices) {
+				this.$iosDeviceOperations.setShouldDispose(false);
+				this.$iOSSimulatorLogProvider.setShouldDispose(false);
+			}
 		}
 
 		if (this.$options.release) {

lib/services/cleanup-service.ts

@@ -13,7 +13,7 @@ export class CleanupService implements ICleanupService {
 		this.pathToCleanupLogFile = $options.cleanupLogFile;
 	}
 
-	public shouldDispose = false;
+	public shouldDispose = true;
 
 	public async addCleanupCommand(commandInfo: ISpawnCommandInfo): Promise<void> {
 		const cleanupProcess = await this.getCleanupProcess();