Skip to content

Commit 2cb0dc3

Browse files
committed
Fix PR comments
1 parent 55b5813 commit 2cb0dc3

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/services/debug-service.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ export class DebugService extends EventEmitter implements IDebugService {
5151
this.$errors.failWithoutHelp(`Unsupported device OS: ${device.deviceInfo.platform}. You can debug your applications only on iOS or Android.`);
5252
}
5353

54-
if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform)) { // TODO: Consider to move this code to ios-debug-service
54+
// TODO: Consider to move this code to ios-debug-service
55+
if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform)) {
5556
if (device.isEmulator && !debugData.pathToAppPackage && debugOptions.debugBrk) {
5657
this.$errors.failWithoutHelp("To debug on iOS simulator you need to provide path to the app package.");
5758
}

lib/services/livesync/livesync-service.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -456,10 +456,10 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
456456
const deviceAction = async (device: Mobile.IDevice): Promise<void> => {
457457
try {
458458
const platform = device.deviceInfo.platform;
459-
const liveSyncService = this.getLiveSyncService(platform);
459+
const platformLiveSyncService = this.getLiveSyncService(platform);
460460
const deviceBuildInfoDescriptor = _.find(deviceDescriptors, dd => dd.identifier === device.deviceInfo.identifier);
461461

462-
liveSyncService.prepareForLiveSync(device, projectData, liveSyncData);
462+
platformLiveSyncService.prepareForLiveSync(device, projectData, liveSyncData);
463463

464464
await this.ensureLatestAppPackageIsInstalledOnDevice({
465465
device,
@@ -475,7 +475,7 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
475475
env: liveSyncData.env
476476
}, { skipNativePrepare: deviceBuildInfoDescriptor.skipNativePrepare });
477477

478-
const liveSyncResultInfo = await liveSyncService.fullSync({
478+
const liveSyncResultInfo = await platformLiveSyncService.fullSync({
479479
projectData, device,
480480
syncAllFiles: liveSyncData.watchAllFiles,
481481
useLiveEdit: liveSyncData.useLiveEdit,

0 commit comments

Comments
 (0)