refactor(preview): rename IGenerateQrCodeOptions to IPrintLiveSyncOptions

Fatme · Fatme · commit 2c14c9692e4d · 2018-11-02T12:51:44.000+02:00
diff --git a/lib/definitions/preview-app-livesync.d.ts b/lib/definitions/preview-app-livesync.d.ts
@@ -24,14 +24,14 @@ declare global {
 
 	interface IPreviewQrCodeService {
 		getPlaygroundAppQrCode(options?: IPlaygroundAppQrCodeOptions): Promise<IDictionary<IQrCodeImageData>>;
-		printLiveSyncQrCode(options: IGenerateQrCodeOptions): Promise<void>;
+		printLiveSyncQrCode(options: IPrintLiveSyncOptions): Promise<void>;
 	}
 
 	interface IPlaygroundAppQrCodeOptions {
 		platform?: string;
 	}
 
-	interface IGenerateQrCodeOptions extends IHasUseHotModuleReloadOption {
+	interface IPrintLiveSyncOptions extends IHasUseHotModuleReloadOption {
 		/**
 		 * If set to true, a link will be shown on console instead of QR code
 		 * Default value is false.
diff --git a/lib/services/livesync/playground/preview-qr-code-service.ts b/lib/services/livesync/playground/preview-qr-code-service.ts
@@ -29,7 +29,7 @@ export class PreviewQrCodeService implements IPreviewQrCodeService {
 		return result;
 	}
 
-	public async printLiveSyncQrCode(options: IGenerateQrCodeOptions): Promise<void> {
+	public async printLiveSyncQrCode(options: IPrintLiveSyncOptions): Promise<void> {
 		const qrCodeUrl = this.$previewSdkService.getQrCodeUrl(options);
 		const url = await this.getShortenUrl(qrCodeUrl);
 

Original file line number	Diff line number	Diff line change
`@@ -24,14 +24,14 @@ declare global {`
`24`	`24`
`25`	`25`	`interface IPreviewQrCodeService {`
`26`	`26`	`getPlaygroundAppQrCode(options?: IPlaygroundAppQrCodeOptions): Promise<IDictionary<IQrCodeImageData>>;`
`27`		`- printLiveSyncQrCode(options: IGenerateQrCodeOptions): Promise<void>;`
	`27`	`+ printLiveSyncQrCode(options: IPrintLiveSyncOptions): Promise<void>;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`interface IPlaygroundAppQrCodeOptions {`
`31`	`31`	`platform?: string;`
`32`	`32`	`}`
`33`	`33`
`34`		`- interface IGenerateQrCodeOptions extends IHasUseHotModuleReloadOption {`
	`34`	`+ interface IPrintLiveSyncOptions extends IHasUseHotModuleReloadOption {`
`35`	`35`	`/**`
`36`	`36`	`* If set to true, a link will be shown on console instead of QR code`
`37`	`37`	`* Default value is false.`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export class PreviewQrCodeService implements IPreviewQrCodeService {`
`29`	`29`	`return result;`
`30`	`30`	`}`
`31`	`31`
`32`		`- public async printLiveSyncQrCode(options: IGenerateQrCodeOptions): Promise<void> {`
	`32`	`+ public async printLiveSyncQrCode(options: IPrintLiveSyncOptions): Promise<void> {`
`33`	`33`	`const qrCodeUrl = this.$previewSdkService.getQrCodeUrl(options);`
`34`	`34`	`const url = await this.getShortenUrl(qrCodeUrl);`
`35`	`35`