Skip to content

Commit 2bd3494

Browse files
Fatme HavaluovaFatme Havaluova
Fatme Havaluova
authored and
Fatme Havaluova
committed
Don't save empty object into package.json file
1. Add plugin that doesn't have plugin variables 2. Open pacakge.json 3. We've added: "<plugin-name>-variables": {}
1 parent fcd0eea commit 2bd3494

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/services/plugin-variables-service.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@ export class PluginVariablesService implements IPluginVariablesService {
2626
values[pluginVariableData.name] = pluginVariableValue;
2727
}).future<void>()()).wait();
2828

29-
this.$projectDataService.initialize(this.$projectData.projectDir);
30-
this.$projectDataService.setValue(this.getPluginVariablePropertyName(pluginData), values).wait();
29+
if(!_.isEmpty(values)) {
30+
this.$projectDataService.initialize(this.$projectData.projectDir);
31+
this.$projectDataService.setValue(this.getPluginVariablePropertyName(pluginData), values).wait();
32+
}
3133
}).future<void>()();
3234
}
3335

0 commit comments

Comments
 (0)