Skip to content

Commit 29bb5b2

Browse files
Fix merge of options during tns run
The `$options` object has the required information for all passed `--` args, but all of them are in `get` methods. Calling `merge` does not get functions (like `get`ers), so we do not receive expected options (like `--release, --keyStorePath`, etc.) in the merged object. In order to fix this just use the `this.$options.argv` which contains the information we need.
1 parent 0c07e2e commit 29bb5b2

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

lib/commands/run.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,7 @@ export class RunCommandBase implements ICommand {
103103
const deployOptions = _.merge<IDeployPlatformOptions>({
104104
projectDir: this.$projectData.projectDir,
105105
clean: true,
106-
release: this.$options.release,
107-
keyStoreAlias: this.$options.keyStoreAlias,
108-
keyStoreAliasPassword: this.$options.keyStoreAliasPassword,
109-
keyStorePassword: this.$options.keyStorePassword,
110-
keyStorePath: this.$options.keyStorePath
111-
}, this.$options);
106+
}, this.$options.argv);
112107

113108
await this.$platformService.deployPlatform(args[0], this.$options, deployOptions, this.$projectData, this.$options);
114109
await this.$platformService.startApplication(args[0], runPlatformOptions, this.$projectData.projectId);

0 commit comments

Comments
 (0)