Fix PR comments + refactoring

Author: Fatme

PublicAPI.md

@@ -53,6 +53,9 @@ const tns = require("nativescript");
 * [sysInfo](#sysinfo)
 	* [getSupportedNodeVersionRange](#getsupportednodeversionrange)
 	* [getSystemWarnings](#getsystemwarnings)
+* [devicesService](#devicesService)
+	* [getAvailableEmulators](#getAvailableEmulators)
+	* [startEmulator](#startEmulator)
 
 ## Module projectService
 
@@ -1198,6 +1201,45 @@ tns.sysInfo.getSystemWarnings()
 	.catch(err => console.error(`Error while trying to get system warnings: ${err}`));
 ```
 
+## devicesService
+The `devicesService` module allows interaction with devices and emulators. You can get a list of the available emulators or start a specific emulator.
+
+### getAvailableEmulators
+The `getAvailableEmulators` method returns object of all running and available emulators. The result is in the following format: 
+```JavaScript
+	{
+		android: {
+			devices: Mobile.IDeviceInfo[],
+			errors: string[]
+		},
+		ios: {
+			devices: Mobile.IDeviceInfo[],
+			errors: string[]
+		}
+	}
+```
+
+This method accepts platform parameter. If provided only devices by specified platform will be returned.
+
+* Usage
+```TypeScript
+tns.devicesService.getAvailableEmulators()
+	.then(availableEmulatorsOutput => {
+		Object.keys(availableEmulatorsOutput)
+			.forEach(platform => {
+				availableEmulatorsOutput[platform].devices.forEach(device => console.log(device));
+			})
+	})
+```
+
+### startEmulator
+The `startEmulator` method starts the emulator specified by provided options. Returns an array of errors if something unexpected happens or null otherwise.
+* Usage
+```TypeScript
+tns.devicesService.startEmulator({imageIdentifier: "my emulator imageIdentifier"})
+	.then(errors => { });
+```
+
 ## How to add a new method to Public API
 CLI is designed as command line tool and when it is used as a library, it does not give you access to all of the methods. This is mainly implementation detail. Most of the CLI's code is created to work in command line, not as a library, so before adding method to public API, most probably it will require some modification.
 For example the `$options` injected module contains information about all `--` options passed on the terminal. When the CLI is used as a library, the options are not populated. Before adding method to public API, make sure its implementation does not rely on `$options`.

lib/common

@@ -91,6 +91,9 @@ interface IDebugOptions {
 	 * If not provided, defaults to 10 seconds.
 	 */
 	timeout?: string;
+	/**
+	 * The sdk version of the emulator.
+	 */
 	sdk?: string;
 }
 

lib/definitions/debug.d.ts

@@ -258,7 +258,6 @@ describe('Platform Service Tests', () => {
 					return {
 						frameworkPackageName: packageName,
 						platformProjectService: new stubs.PlatformProjectServiceStub(),
-						emulatorServices: undefined,
 						projectRoot: "",
 						normalizedPlatformName: "",
 						appDestinationDirectoryPath: "",

test/platform-service.ts

@@ -835,7 +835,6 @@ export class InjectorStub extends Yok implements IInjector {
 		this.register("hooksService", HooksServiceStub);
 		this.register('projectDataService', ProjectDataService);
 		this.register('devicePlatformsConstants', DevicePlatformsConstants);
-		this.register("emulatorPlatformService", EmulatorPlatformService);
 		this.register("androidResourcesMigrationService", AndroidResourcesMigrationServiceStub);
 		this.register("platformService", PlatformServiceStub);
 		this.register("commandsService", CommandsService);