Skip to content

Commit 2632201

Browse files
committed
fix: don't fail if some unhandled errors occurs in application
1 parent 6310203 commit 2632201

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

lib/services/livesync/playground/preview-sdk-service.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ export class PreviewSdkService implements IPreviewSdkService {
77
private instanceId: string = null;
88
public connectedDevices: Device[] = [];
99

10-
constructor(private $errors: IErrors,
11-
private $logger: ILogger,
10+
constructor(private $logger: ILogger,
1211
private $httpClient: Server.IHttpClient,
1312
private $config: IConfiguration) {
1413
}
@@ -62,7 +61,7 @@ export class PreviewSdkService implements IPreviewSdkService {
6261
this.$logger.trace("Received onRestartMessage event.");
6362
},
6463
onUncaughtErrorMessage: () => {
65-
this.$errors.failWithoutHelp("Error while communicating with preview app.");
64+
this.$logger.warn("The Preview app has terminated unexpectedly. Please run it again to get a detailed crash report.");
6665
},
6766
onDeviceConnectedMessage: (deviceConnectedMessage: DeviceConnectedMessage) => ({ }),
6867
onDeviceConnected: (device: Device) => {

test/services/preview-sdk-service.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
import { PreviewSdkService } from "../../lib/services/livesync/playground/preview-sdk-service";
22
import { Yok } from "../../lib/common/yok";
33
import { assert } from "chai";
4-
import { LoggerStub, ErrorsStub } from "../stubs";
4+
import { LoggerStub } from "../stubs";
55

66
const getPreviewSdkService = (): IPreviewSdkService => {
77
const testInjector = new Yok();
88
testInjector.register("logger", LoggerStub);
9-
testInjector.register("errors", ErrorsStub);
109
testInjector.register("config", {});
1110
testInjector.register("previewSdkService", PreviewSdkService);
1211

0 commit comments

Comments
 (0)