Skip to content

Commit 219a1ad

Browse files
author
IceBuildUser
committed
Merge remote-tracking branch 'origin/release' into HEAD
2 parents 37bf964 + 7d7a1e6 commit 219a1ad

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

lib/android-tools-info.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,11 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
128128
}
129129

130130
if(!toolsInfoData.supportRepositoryVersion) {
131-
let invalidSupportLibAdditionalMsg = 'Run `$ android` to manage the Android Support Repository.';
131+
let invalidSupportLibAdditionalMsg = 'Run `$ android` to manage the Local Maven repository for Support Libraries.';
132132
if(!isAndroidHomeValid) {
133133
invalidSupportLibAdditionalMsg += ' In case you already have it installed, make sure `ANDROID_HOME` environment variable is set correctly.';
134134
}
135-
this.printMessage(`You need to have Android SDK ${AndroidToolsInfo.MIN_REQUIRED_COMPILE_TARGET} or later and the latest Android Support Repository installed on your system.`, invalidSupportLibAdditionalMsg);
135+
this.printMessage(`You need to have Android SDK ${AndroidToolsInfo.MIN_REQUIRED_COMPILE_TARGET} or later and the latest Local Maven repository for Support Libraries installed on your system.`, invalidSupportLibAdditionalMsg);
136136
detectedErrors = true;
137137
}
138138

lib/constants.ts

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export var LIVESYNC_EXCLUDED_DIRECTORIES = ["app_resources"];
1515
export var TESTING_FRAMEWORKS = ['jasmine', 'mocha', 'qunit'];
1616
export let TEST_RUNNER_NAME = "nativescript-unit-test-runner";
1717
export let LIVESYNC_EXCLUDED_FILE_PATTERNS = ["**/*.js.map", "**/*.ts"];
18+
export let XML_FILE_EXTENSION = ".xml";
1819

1920
export class ReleaseType {
2021
static MAJOR = "major";

lib/services/android-project-service.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -327,10 +327,11 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
327327
this.$fs.ensureDirectoryExists(resourcesDestinationDirectoryPath).wait();
328328
shell.cp("-Rf", path.join(pluginPlatformsFolderPath, "*"), resourcesDestinationDirectoryPath);
329329

330-
let pluginConfigurationFilePath = path.join(resourcesDestinationDirectoryPath, this.platformData.configurationFileName);
331-
if (this.$fs.exists(pluginConfigurationFilePath).wait()) {
332-
this.$pluginVariablesService.interpolate(pluginData, pluginConfigurationFilePath).wait();
333-
}
330+
(this.$fs.enumerateFilesInDirectorySync(resourcesDestinationDirectoryPath, file => this.$fs.getFsStats(file).wait().isDirectory() || path.extname(file) === constants.XML_FILE_EXTENSION) || [])
331+
.forEach(file => {
332+
this.$logger.trace(`Interpolate data for plugin file: ${file}`);
333+
this.$pluginVariablesService.interpolate(pluginData, file).wait();
334+
});
334335
}
335336

336337
// Copy include.gradle file

lib/xml-validator.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"use strict";
33

44
import { EOL } from "os";
5+
import * as constants from "./constants";
56

67
export class XmlValidator implements IXmlValidator {
78
constructor(private $fs: IFileSystem,
@@ -11,7 +12,7 @@ export class XmlValidator implements IXmlValidator {
1112
return (() => {
1213
let xmlHasErrors = false;
1314
sourceFiles
14-
.filter(file => _.endsWith(file, ".xml"))
15+
.filter(file => _.endsWith(file, constants.XML_FILE_EXTENSION))
1516
.forEach(file => {
1617
let errorOutput = this.getXmlFileErrors(file).wait();
1718
let hasErrors = !!errorOutput;

0 commit comments

Comments
 (0)