Skip to content

Commit 1f98175

Browse files
committed
Allow the user to manually set Chrome app name
fixes #632
1 parent 728d295 commit 1f98175

File tree

5 files changed

+12
-3
lines changed

5 files changed

+12
-3
lines changed

config/config.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44
"PROXY_PORT": 8888,
55
"PROXY_HOSTNAME": "127.0.0.1",
66
"TYPESCRIPT_COMPILER_OPTIONS": {},
7-
"CI_LOGGER": false
7+
"CI_LOGGER": false,
8+
"ANDROID_DEBUG_UI_MAC": "Google Chrome"
89
}

docs/man_pages/project/testing/debug-android.md

+5
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ Debugs your project on a connected device, in a native emulator or in Genymotion
3535

3636
* You must have Chrome installed on your system.
3737

38+
<% if(isMacOS || isWindows) { %>
39+
If you are using Chrome app with a non-standard name (for example, from a nightly build), you need to change it in
40+
the [config file](<%= require("path").join(__dirname, "../config/config.json") %>).
41+
<% } %>
42+
3843
### Related Commands
3944

4045
Command | Description

lib/common

lib/config.ts

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export class Configuration extends configBaseLib.ConfigBase implements IConfigur
1111
DEBUG = false;
1212
TYPESCRIPT_COMPILER_OPTIONS = {};
1313
USE_PROXY = false;
14+
ANDROID_DEBUG_UI_MAC = "Google Chrome";
1415

1516
/*don't require logger and everything that has logger as dependency in config.js due to cyclic dependency*/
1617
constructor(protected $fs: IFileSystem) {

lib/declarations.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ interface IDependencyData {
3232

3333
interface IStaticConfig extends Config.IStaticConfig { }
3434

35-
interface IConfiguration extends Config.IConfig { }
35+
interface IConfiguration extends Config.IConfig {
36+
ANDROID_DEBUG_UI_MAC: string;
37+
}
3638

3739
interface IApplicationPackage {
3840
packageName: string;

0 commit comments

Comments
 (0)