Skip to content

Commit 1f6beef

Browse files
Merge pull request #4869 from NativeScript/tachev/update-migrate-deps
fix: add forgotten migrate dependencies for Vue and Angular apps
2 parents 9fb869e + 0fffc64 commit 1f6beef

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

lib/controllers/migrate-controller.ts

+21-2
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,15 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
6969
{ packageName: "nativescript-datetimepicker", verifiedVersion: "1.1.0" },
7070
{ packageName: "kinvey-nativescript-sdk", verifiedVersion: "4.2.1" },
7171
{ packageName: "nativescript-plugin-firebase", verifiedVersion: "9.0.2" },
72-
{ packageName: "nativescript-vue", verifiedVersion: "2.3.0" },
72+
{
73+
packageName: "nativescript-vue", verifiedVersion: "2.3.0",
74+
shouldMigrateAction: async (projectData: IProjectData, allowInvalidVersions: boolean) => {
75+
const dependency = { packageName: "nativescript-vue", verifiedVersion: "2.3.0", isDev: false };
76+
const result = this.hasDependency(dependency, projectData) && await this.shouldMigrateDependencyVersion(dependency, projectData, allowInvalidVersions);
77+
return result;
78+
},
79+
migrateAction: this.migrateNativeScriptVue.bind(this)
80+
},
7381
{
7482
packageName: "nativescript-angular", verifiedVersion: "8.0.2",
7583
shouldMigrateAction: async (projectData: IProjectData, allowInvalidVersions: boolean) => {
@@ -396,7 +404,18 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
396404
{ packageName: "@angular/platform-browser", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
397405
{ packageName: "@angular/router", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
398406
{ packageName: "rxjs", verifiedVersion: "6.3.3", shouldAddIfMissing: true },
399-
{ packageName: "zone.js", verifiedVersion: "0.9.1", shouldAddIfMissing: true }
407+
{ packageName: "zone.js", verifiedVersion: "0.9.1", shouldAddIfMissing: true },
408+
{ packageName: "@angular/animations", verifiedVersion: "8.0.0" },
409+
{ packageName: "@angular/compiler-cli", verifiedVersion: "8.0.0", isDev: true },
410+
{ packageName: "@ngtools/webpack", verifiedVersion: "8.0.0", isDev: true }
411+
];
412+
413+
return dependencies;
414+
}
415+
416+
private async migrateNativeScriptVue(): Promise<IMigrationDependency[]> {
417+
const dependencies = [
418+
{ packageName: "nativescript-vue-template-compiler", verifiedVersion: "2.3.0", isDev: true }
400419
];
401420

402421
return dependencies;

0 commit comments

Comments
 (0)