make livesync work with renamed files and folders (#3042)

* added special check for file changes on Mac

* fix missing imports in tests

* add dir check, modified file check

* check isDirModified before anything else to save time

* updates after review

* bring back check for symlinks

* add check for modification in bot files and folders

* fixed lint

Author: Plamen5kov

lib/services/project-changes-service.ts

@@ -68,6 +68,7 @@ export class ProjectChangesService implements IProjectChangesService {
 				path.join(projectData.projectDir, NODE_MODULES_FOLDER_NAME, "tns-ios-inspector"),
 				projectData,
 				this.fileChangeRequiresBuild);
+
 			if (this._newFiles > 0) {
 				this._changesInfo.modulesChanged = true;
 			}
@@ -218,20 +219,20 @@ export class ProjectChangesService implements IProjectChangesService {
 	}
 
 	private containsNewerFiles(dir: string, skipDir: string, projectData: IProjectData, processFunc?: (filePath: string, projectData: IProjectData) => boolean): boolean {
+		const dirFileStat = this.$fs.getFsStats(dir);
+		if (this.isFileModified(dirFileStat, dir)) {
+			return true;
+		}
+
 		let files = this.$fs.readDirectory(dir);
 		for (let file of files) {
 			let filePath = path.join(dir, file);
 			if (filePath === skipDir) {
 				continue;
 			}
 
-			let fileStats = this.$fs.getFsStats(filePath);
-
-			let changed = fileStats.mtime.getTime() >= this._outputProjectMtime || fileStats.ctime.getTime() >= this._outputProjectCTime;
-			if (!changed) {
-				let lFileStats = this.$fs.getLsStats(filePath);
-				changed = lFileStats.mtime.getTime() >= this._outputProjectMtime || lFileStats.ctime.getTime() >= this._outputProjectCTime;
-			}
+			const fileStats = this.$fs.getFsStats(filePath);
+			let changed = this.isFileModified(fileStats, filePath);
 
 			if (changed) {
 				if (processFunc) {
@@ -250,10 +251,24 @@ export class ProjectChangesService implements IProjectChangesService {
 					return true;
 				}
 			}
+
 		}
 		return false;
 	}
 
+	private isFileModified(filePathStat: IFsStats, filePath: string): boolean {
+		let changed = filePathStat.mtime.getTime() >= this._outputProjectMtime ||
+			filePathStat.ctime.getTime() >= this._outputProjectCTime;
+
+		if (!changed) {
+			let lFileStats = this.$fs.getLsStats(filePath);
+			changed = lFileStats.mtime.getTime() >= this._outputProjectMtime ||
+				lFileStats.ctime.getTime() >= this._outputProjectCTime;
+		}
+
+		return changed;
+	}
+
 	private fileChangeRequiresBuild(file: string, projectData: IProjectData) {
 		if (path.basename(file) === "package.json") {
 			return true;

test/project-changes-service.ts

@@ -26,7 +26,6 @@ class ProjectChangesServiceTest extends BaseServiceTest {
 		this.injector.register("platformsData", PlatformsData);
 		this.injector.register("androidProjectService", {});
 		this.injector.register("iOSProjectService", {});
-
 		this.injector.register("fs", FileSystem);
 		this.injector.register("devicePlatformsConstants", {});
 		this.injector.register("devicePlatformsConstants", {});