Skip to content

Commit 1cffefb

Browse files
Mitko-Kerezovrosen-vladimirov
authored andcommitted
Upgrade ws module (#2579)
The newer version doesn't require `bufferutil` or `utf-8-validate` both of which have native V8 code which we are trying to get rid of. Debugging still works with this new version - tested on three different OS X machines with `tns debug ios --chrome` command.
1 parent a39cf09 commit 1cffefb

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lib/device-sockets/ios/socket-proxy-factory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class SocketProxyFactory implements ISocketProxyFactory {
7878
// We store the socket that connects us to the device in the upgrade request object itself and later on retrieve it
7979
// in the connection callback.
8080

81-
let server = ws.createServer(<any>{
81+
let server = new ws.Server(<any>{
8282
port: localPort,
8383
verifyClient: (info: any, callback: Function) => {
8484
this.$logger.info("Frontend client connected.");

package.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
"dependencies": {
3030
"bplist-parser": "0.1.0",
3131
"bufferpack": "0.0.6",
32-
"bufferutil": "https://github.com/telerik/bufferutil/tarball/v1.0.1.5",
3332
"byline": "4.2.1",
3433
"chalk": "1.1.0",
3534
"chokidar": "^1.6.1",
@@ -70,10 +69,9 @@
7069
"source-map": "0.5.6",
7170
"tabtab": "https://github.com/Icenium/node-tabtab/tarball/master",
7271
"temp": "0.8.3",
73-
"utf-8-validate": "https://github.com/telerik/utf-8-validate/tarball/v1.0.1.5",
7472
"uuid": "3.0.1",
7573
"winreg": "0.0.17",
76-
"ws": "0.7.1",
74+
"ws": "2.2.0",
7775
"xcode": "https://github.com/NativeScript/node-xcode/archive/1.4.0.tar.gz",
7876
"xmldom": "0.1.21",
7977
"xmlhttprequest": "https://github.com/telerik/node-XMLHttpRequest/tarball/master",

0 commit comments

Comments
 (0)