Skip to content

Commit 1514f27

Browse files
committed
removing unnecessary functionality
1 parent 33190a5 commit 1514f27

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

lib/services/android-project-service.ts

+1-12
Original file line numberDiff line numberDiff line change
@@ -307,18 +307,7 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
307307
}
308308

309309
public prepareProject(): IFuture<void> {
310-
return (() => {
311-
let resDestinationDir = this.getAppResourcesDestinationDirectoryPath().wait();
312-
let androidManifestPath = path.join(resDestinationDir, this.platformData.configurationFileName);
313-
314-
// In case the file is not correct, looks like we are still using the default AndroidManifest.xml from runtime and the current file (in res dir)
315-
// should be merged with it.
316-
if (this.isAndroidManifestFileCorrect(androidManifestPath).wait()) {
317-
// Delete the AndroidManifest.xml file from res directory as the runtime will consider it as addition to the one in src/main and will try to merge them.
318-
// However now they are the same file.
319-
this.$fs.deleteFile(androidManifestPath).wait();
320-
}
321-
}).future<void>()();
310+
return Future.fromResult();
322311
}
323312

324313
public ensureConfigurationFileInAppResources(): IFuture<void> {

lib/services/platform-service.ts

-6
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,6 @@ export class PlatformService implements IPlatformService {
259259
sourceFiles = sourceFiles.filter(source => source.indexOf(testsFolderPath) === -1);
260260
}
261261

262-
let hasTnsModulesInAppFolder = this.$fs.exists(path.join(appSourceDirectoryPath, constants.TNS_MODULES_FOLDER_NAME)).wait();
263-
if (hasTnsModulesInAppFolder && this.$projectData.dependencies && this.$projectData.dependencies[constants.TNS_CORE_MODULES_NAME]) {
264-
this.$logger.warn("You have tns_modules dir in your app folder and tns-core-modules in your package.json file. Tns_modules dir in your app folder will not be used and you can safely remove it.");
265-
sourceFiles = sourceFiles.filter(source => !minimatch(source, `**/${constants.TNS_MODULES_FOLDER_NAME}/**`, { nocase: true }));
266-
}
267-
268262
// verify .xml files are well-formed
269263
this.$xmlValidator.validateXmlFiles(sourceFiles).wait();
270264

0 commit comments

Comments
 (0)